Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TFM in tests to net8.0 #69669

Merged
merged 3 commits into from
Sep 4, 2023
Merged

Update TFM in tests to net8.0 #69669

merged 3 commits into from
Sep 4, 2023

Conversation

jjonescz
Copy link
Member

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Aug 23, 2023
@jjonescz jjonescz mentioned this pull request Aug 23, 2023
Merged
@jjonescz jjonescz marked this pull request as ready for review August 23, 2023 12:10
@jjonescz jjonescz requested review from a team as code owners August 23, 2023 12:10
jcouv
jcouv reviewed Aug 31, 2023
View reviewed changes
src/Compilers/VisualBasic/Test/Emit/Attributes/AttributeTests_WellKnownAttributes.vb
@@ -15,6 +15,8 @@ Imports Microsoft.CodeAnalysis.VisualBasic.Symbols.Metadata.PE
Imports Microsoft.CodeAnalysis.VisualBasic.Syntax
Imports Roslyn.Test.Utilities

#Disable Warning SYSLIB0050 ' 'TypeAttributes.Serializable' is obsolete
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the context for this? I'm not seeing that attribute as obsolete on https://learn.microsoft.com/en-us/dotnet/api/system.reflection.typeattributes?view=net-8.0
If it is obsolete, are we supposed to use something else instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's suppressed at other places that were upgraded to net8 previously, e.g.:

roslyn/src/Compilers/VisualBasic/Portable/Symbols/Metadata/PE/PENamedTypeSymbol.vb

Line 223 in 32b3fc0

#Disable Warning SYSLIB0050 ' 'TypeAttributes.Serializable' is obsolete

See also comment in https://github.com/dotnet/roslyn/pull/68627/files

@jcouv jcouv self-assigned this Aug 31, 2023
jcouv
jcouv reviewed Aug 31, 2023
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done with review pass (iteration 2). I just have a question on the obsoleted attribute

AlekseyTs
AlekseyTs approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 2)

jcouv
jcouv approved these changes Sep 3, 2023
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 2)

@jjonescz jjonescz enabled auto-merge (squash) September 4, 2023 07:34
@jjonescz jjonescz merged commit 4d8f347 into dotnet:main Sep 4, 2023
@jjonescz jjonescz deleted the net8-tests branch September 4, 2023 09:48
@ghost ghost added this to the Next milestone Sep 4, 2023
@allisonchou allisonchou mentioned this pull request Sep 5, 2023
Closed
@Cosifne Cosifne modified the milestones: Next, 17.8 P3 Sep 25, 2023
omajid added a commit to omajid/dotnet-roslyn that referenced this pull request Nov 13, 2023
@omajid
Make eng/build.sh --test run more unit tests
91bbbff 
A few months ago, I could use the following to build roslyn on Linux and
run (many of?) its unit tests:

    $ ./eng/build.sh --restore --build --pack --test

Unfortunately, PR dotnet#69669 (commit
4d8f347) changed how that works. That
PR changed the default build target of many projects to net8.0, and the
test runner seems to be running only 7.0 projects. After that commit,
the above command shows only one set of unit tests running:

    Running tests in 1 partitions
      1 running,  0 queued,  0 completed
      0 running,  0 queued,  1 completed
    ================
    Microsoft.CodeAnalysis.UnitTests_0 PASSED 00:00:45.4625833
    ================

Adding the net8.0 as a tfm target in the eng/build.sh makes us run more
tests again:

    ================
    Microsoft.CodeAnalysis.Scripting.UnitTests_12                     PASSED 00:00:03.9577625
    Microsoft.CodeAnalysis.ExternalAccess.RazorCompiler.UnitTests_10  PASSED 00:00:04.9223846
    VBCSCompiler.UnitTests_20                                         PASSED 00:00:23.7411654
    Microsoft.CodeAnalysis.CSharp.EndToEnd.UnitTests_4                PASSED 00:00:27.8150736
    Microsoft.Build.Tasks.CodeAnalysis.UnitTests_0                    PASSED 00:00:31.9628642
    Microsoft.CodeAnalysis.CSharp.Scripting.UnitTests_6               PASSED 00:00:33.1929440
    Microsoft.CodeAnalysis.VisualBasic.Syntax.UnitTests_18            PASSED 00:00:33.5702799
    Microsoft.CodeAnalysis.CSharp.CommandLine.UnitTests_1             PASSED 00:00:39.4990867
    Microsoft.CodeAnalysis.CSharp.IOperation.UnitTests_5              PASSED 00:00:52.4321826
    Microsoft.CodeAnalysis.UnitTests_13                               PASSED 00:00:53.3982241
    Roslyn.Compilers.VisualBasic.IOperation.UnitTests_19              PASSED 00:00:53.7378359
    Microsoft.CodeAnalysis.UnitTests_14                               PASSED 00:00:54.3801182
    Microsoft.CodeAnalysis.CSharp.Syntax.UnitTests_9                  PASSED 00:01:17.6610151
    Microsoft.CodeAnalysis.Rebuild.UnitTests_11                       PASSED 00:01:22.3798957
    Microsoft.CodeAnalysis.VisualBasic.Symbol.UnitTests_17            PASSED 00:01:29.8493252
    Microsoft.CodeAnalysis.VisualBasic.Semantic.UnitTests_16          FAILED 00:01:50.8836743
    Microsoft.CodeAnalysis.VisualBasic.Emit.UnitTests_15              FAILED 00:03:35.7901555
    Microsoft.CodeAnalysis.CSharp.Symbol.UnitTests_8                  FAILED 00:04:06.2959522
    Microsoft.CodeAnalysis.CSharp.Emit.UnitTests_2                    FAILED 00:05:27.2969811
    Microsoft.CodeAnalysis.CSharp.Emit2.UnitTests_3                   FAILED 00:06:26.4284098
    Microsoft.CodeAnalysis.CSharp.Semantic.UnitTests_7                FAILED 00:08:06.2821945
    ================
@omajid omajid mentioned this pull request Nov 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@genlu genlu genlu left review comments

@333fred 333fred 333fred approved these changes

@AlekseyTs AlekseyTs AlekseyTs approved these changes

@jcouv jcouv jcouv approved these changes

Assignees

@jcouv jcouv

Labels
Area-Compilers Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.8 P3
Development

Successfully merging this pull request may close these issues.
6 participants
@jjonescz @genlu @333fred @AlekseyTs @jcouv @Cosifne