Stay on the UI thread if it's blocked waiting for us #64813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were jumping to the background thread here since the rest of the method doesn't need to run on the UI thead. Since a number of legacy callers may be running us under a JoinableTaskFactory.Run(), we should stay on the UI thread in that case rather than wait for the thread pool which could also be starved. Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1637719
arunchndr
approved these changes
Oct 18, 2022
JoeRobich
approved these changes
Oct 19, 2022
ghost
added this to the 
| @@ -144,14 +151,16 @@ public Task<VisualStudioProject> CreateAndAddToWorkspaceAsync(string projectSyst | |||
| { | |||
| w.OnProjectAdded(projectInfo); | |||
| } | |||
| }).ConfigureAwait(false); | |||
| }); | |||
There was a problem hiding this comment.
would prefer an explicit ConfigureAwait(true) here.
|
|
||
| // Ensure that other VS contexts get accurate information that the UIContext for this language is now active. | ||
| // This is not cancellable as we have already mutated the solution. | ||
| await _visualStudioWorkspaceImpl.RefreshProjectExistsUIContextForLanguageAsync(language, CancellationToken.None).ConfigureAwait(false); | ||
| await _visualStudioWorkspaceImpl.RefreshProjectExistsUIContextForLanguageAsync(language, CancellationToken.None); |
There was a problem hiding this comment.
would prefer an explicit ConfigureAwait(true) here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were jumping to the background thread here since the rest of the method doesn't need to run on the UI thead. Since a number of legacy callers may be running us under a JoinableTaskFactory.Run(), we should stay on the UI thread in that case rather than wait for the thread pool which could also be starved.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1637719