Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encoding serialization #64625

Merged
merged 12 commits into from
Oct 19, 2022
Merged

Encoding serialization #64625

merged 12 commits into from
Oct 19, 2022

Conversation

tmat
Copy link
Member

@tmat tmat commented Oct 11, 2022 •
edited
Loading

This will be needed for message-pack serialization of SourceText.

@tmat tmat requested review from a team as code owners October 11, 2022 00:13
@tmat
Copy link
Member Author

tmat commented Oct 11, 2022

@CyrusNajmabadi PTAL

@tmat tmat force-pushed the EncodingSerialization branch from 919e711 to 5768169 Compare October 11, 2022 04:21
@runfoapp runfoapp bot mentioned this pull request Oct 11, 2022
Closed
cston
cston approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@cston cston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compiler changes LGTM.

This was referenced Oct 12, 2022
Open
Closed
@jcouv jcouv self-assigned this Oct 14, 2022
jcouv
jcouv reviewed Oct 14, 2022
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done with review pass (iteration 7). Only minor questions

jcouv
jcouv approved these changes Oct 14, 2022
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 8)

@tmat tmat enabled auto-merge (squash) October 14, 2022 23:56
@tmat tmat disabled auto-merge October 16, 2022 16:56
@runfoapp runfoapp bot mentioned this pull request Oct 18, 2022
Closed
@tmat tmat merged commit e4e09c7 into dotnet:main Oct 19, 2022
@tmat tmat deleted the EncodingSerialization branch October 19, 2022 15:20
@ghost ghost added this to the Next milestone Oct 19, 2022
@allisonchou allisonchou mentioned this pull request Oct 22, 2022
Closed
@RikkiGibson RikkiGibson modified the milestones: Next, 17.5 P1 Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcouv jcouv jcouv approved these changes

@cston cston cston approved these changes

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Assignees

@jcouv jcouv

Labels
Area-Compilers
Projects
None yet
Milestone
17.5 P1
Development

Successfully merging this pull request may close these issues.
5 participants
@tmat @CyrusNajmabadi @cston @jcouv @RikkiGibson