Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change operator when negating relational patterns with numeric values #64594

Merged
merged 6 commits into from
Oct 12, 2022
Merged

Change operator when negating relational patterns with numeric values #64594

merged 6 commits into from
Oct 12, 2022

Conversation

kimsey0
Copy link
Contributor

@kimsey0 kimsey0 commented Oct 9, 2022

Fixes #64558.

@kimsey0 kimsey0 requested a review from a team as a code owner October 9, 2022 22:50
@ghost ghost added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Oct 9, 2022
CyrusNajmabadi
CyrusNajmabadi requested changes Oct 10, 2022
View reviewed changes
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking very good. minor changes requested.

@build-analysis build-analysis bot mentioned this pull request Oct 10, 2022
Closed
@kimsey0
Copy link
Contributor Author

kimsey0 commented Oct 10, 2022

@CyrusNajmabadi: Thanks for the review. I implemented the requested changes. There's one open discussion left above.

@CyrusNajmabadi
Copy link
Member

Thanks for the awesome PR! :)

@kimsey0
Copy link
Contributor Author

kimsey0 commented Oct 11, 2022

I can't quite figure out if the failing test here is my fault, since I can't see the full test name in the logs and have a number of tests that fail locally on main, which makes it hard to reproduce the exact problem from the pipeline.

@CyrusNajmabadi CyrusNajmabadi merged commit 40782d7 into dotnet:main Oct 12, 2022
@ghost ghost added this to the Next milestone Oct 12, 2022
@kimsey0 kimsey0 deleted the negating-relational-patterns branch October 12, 2022 07:02
@allisonchou allisonchou mentioned this pull request Oct 14, 2022
Closed
@RikkiGibson RikkiGibson modified the milestones: Next, 17.5 P1 Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Assignees
No one assigned
Labels
Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee.
Projects
None yet
Milestone
17.5 P1
Development

Successfully merging this pull request may close these issues.

Improve negation of relational patterns with numeric values in refactorings
3 participants
@kimsey0 @CyrusNajmabadi @RikkiGibson