Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instrumentation to investigate flakiness in ConstantFolding_01 #64404

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

jcouv
Copy link
Member

@jcouv jcouv commented Sep 30, 2022

Trying to troubleshoot #63782

I'm trying to figure out whether the flakiness is in the production of IL or in the verification of IL.
The additional instrumentation should output the IL (as text) in case of failure and capture a crash dump.

@jcouv jcouv self-assigned this Sep 30, 2022
@jcouv jcouv added Test Test failures in roslyn-CI Flaky and removed Area-Compilers labels Sep 30, 2022
@jcouv jcouv marked this pull request as ready for review October 3, 2022 06:54
@jcouv jcouv requested a review from a team as a code owner October 3, 2022 06:54
@jcouv
Copy link
Member Author

jcouv commented Oct 4, 2022

@dotnet/roslyn-compiler for a small test-only change. Thanks

@jcouv
Copy link
Member Author

jcouv commented Oct 6, 2022

I'll go ahead and merge this test-only change with single sign-off. Thanks

@jcouv jcouv merged commit 846bbde into dotnet:main Oct 6, 2022
@jcouv jcouv deleted the il-verify branch October 6, 2022 17:53
@ghost ghost added this to the Next milestone Oct 6, 2022
@RikkiGibson RikkiGibson modified the milestones: Next, 17.5 P1 Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Flaky Test Test failures in roslyn-CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants