Fix generate type dialog invoked on type argument in a base list #63378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Community
Youssef1313
commented
Aug 13, 2022
Comment on lines
+173
to
+172
| Assert.Equal(assertGenerateTypeDialogOptions.IsPublicOnlyAccessibility, generateTypeDialogOptions.IsPublicOnlyAccessibility); | ||
| Assert.Equal(assertGenerateTypeDialogOptions.TypeKindOptions, generateTypeDialogOptions.TypeKindOptions); | ||
| Assert.Equal(assertGenerateTypeDialogOptions.IsAttribute, generateTypeDialogOptions.IsAttribute); |
There was a problem hiding this comment.
This produces better assertion failures.
|
Can someone review this PR please? Thanks! |
jmarolf
approved these changes
Sep 19, 2022
| @@ -2309,6 +2309,105 @@ public struct Bar | |||
| isNewFile: false, | |||
| assertGenerateTypeDialogOptions: new GenerateTypeDialogOptions(false, TypeKindOptions.Class | TypeKindOptions.Structure, false)); | |||
| } | |||
|
|
|||
| [Fact, Trait(Traits.Feature, Traits.Features.CodeActionsGenerateType)] | |||
There was a problem hiding this comment.
don't need the trait. should already be on the type.
CyrusNajmabadi
approved these changes
Nov 10, 2022
|
Thanks! |
auto-merge was automatically disabled
November 10, 2022 21:30
Head branch was pushed to by a user without write access
|
@Youssef1313 do you want to bring this up to main so it can be merged? |
Youssef1313
force-pushed
the
issues/63280
branch
from
84518b3 to
5743730
Compare
|
Sure. Let's see if it will turn green. |
|
@CyrusNajmabadi This is green. |
|
Thanks! |
This was referenced Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #63280