Account for possible cache invalidation on a different thread in assert. #59635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlekseyTs
reviewed
Feb 18, 2022
| @@ -1169,7 +1169,9 @@ public INamedTypeSymbol CreateNativeIntegerTypeSymbol(bool signed) | |||
| { | |||
| val = CommonGetTypeByMetadataName(fullyQualifiedMetadataName); | |||
| var result = _getTypeCache.TryAdd(fullyQualifiedMetadataName, val); | |||
| Debug.Assert(result || (_getTypeCache.TryGetValue(fullyQualifiedMetadataName, out var addedType) && ReferenceEquals(addedType, val))); | |||
| Debug.Assert(result | |||
| || !_getTypeCache.TryGetValue(fullyQualifiedMetadataName, out var addedType) // Could fail if the type was already evicted from the cache | |||
There was a problem hiding this comment.
Or if we add a type we should always get the same instance?
There was a problem hiding this comment.
Or if we add a type we should always get the same instance?
I believe it should always be the same instance. This API effectively just walks through every assembly and looks for the member symbols from the assembly, and (in C#) gets the public version. Those should not be changing.
|
@dotnet/roslyn-compiler For the second review. |
|
@dotnet/roslyn-compiler for a second review please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt at fixing #59395. Reviewing the codepath I don't see any other obvious points that could cause the assert to fail, so if it continues to reproduce after this change we can look at further logging to determine the root cause.