Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/rename_UI_rework Merge Main #59201

Merged
920 commits merged into from
Feb 2, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
920 commits
Select commit Hold shift + click to select a range
0325cd1
merge main
akhera99 Jan 7, 2022
f028ed9
Merge pull request #58697 from dotnet/merges/release/dev17.1-to-relea…
dotnet-bot Jan 7, 2022
b3686aa
Fix typo in folder name
jasonmalinowski Jan 7, 2022
2cb2ed8
fedback
akhera99 Jan 7, 2022
350e378
Delete Microsoft.CodeAnalysis.Workspaces.Desktop.UnitTests
jasonmalinowski Jan 7, 2022
c3e8e6d
Fix MemoryExtensions.TrimStart (#58587)
jcouv Jan 7, 2022
36a0c92
fix bug
akhera99 Jan 7, 2022
a957a12
Merge pull request #58694 from CyrusNajmabadi/convertSwitchCast
CyrusNajmabadi Jan 7, 2022
0e5c679
Fix a few param-nullchecking parsing bugs (#58644)
RikkiGibson Jan 7, 2022
ffde321
Merge pull request #58707 from dotnet/merges/release/dev17.1-to-main
dotnet-bot Jan 7, 2022
afe0c2c
Merge pull request #58708 from dotnet/merges/release/dev17.1-to-relea…
dotnet-bot Jan 7, 2022
e9b3aa1
Merge branch 'main' into gen-override-type-constraint
Youssef1313 Jan 7, 2022
13a91f0
Merge pull request #55737 from akhera99/inline_hints_double_click
akhera99 Jan 7, 2022
fcc0827
Implement GetTypesByMetadataName (#58366)
333fred Jan 7, 2022
4052d3c
Move responsive completion configuration to state reset service
sharwell Jan 6, 2022
5c8d5ab
Merge pull request #58714 from dotnet/merges/release/dev17.1-to-main
dotnet-bot Jan 7, 2022
887ccf1
Merge pull request #58715 from dotnet/merges/release/dev17.1-to-relea…
dotnet-bot Jan 7, 2022
dc55402
Localized file check-in by OneLocBuild Task: Build definition ID 327:…
dotnet-bot Jan 7, 2022
b72b227
Localized file check-in by OneLocBuild Task: Build definition ID 327:…
dotnet-bot Jan 7, 2022
6ba66ac
Localized file check-in by OneLocBuild Task: Build definition ID 327:…
dotnet-bot Jan 7, 2022
338ed4e
Localized file check-in by OneLocBuild Task: Build definition ID 327:…
dotnet-bot Jan 7, 2022
1f66342
Deduplicate references in CommandLineProject.CreateProjectInfo
jasonmalinowski Jan 7, 2022
5f98096
Merge pull request #58698 from dotnet/merges/main-to-main-vs-deps
dotnet-bot Jan 7, 2022
ef242b1
Merge pull request #58656 from sharwell/state-reset
sharwell Jan 7, 2022
bc76245
Merge pull request #58701 from jasonmalinowski/fix-metadata-reference…
jasonmalinowski Jan 7, 2022
1c78d70
Don't run CI for docs-only changes (#58723)
Youssef1313 Jan 8, 2022
a07da68
Merge pull request #58721 from dotnet/locfiles/ad44454d-e250-48a6-aef…
Cosifne Jan 8, 2022
d53ac95
Remove implicit conversion from string to `ReadOnlySpan<T>` from test…
AlekseyTs Jan 8, 2022
cd72f27
Merge remote-tracking branch 'upstream/main' into lambdaDefaultValue
CyrusNajmabadi Jan 8, 2022
eb9cfb9
Merge remote-tracking branch 'upstream/main' into lambdaDefaultValue
CyrusNajmabadi Jan 8, 2022
9786f7c
Minor simplification in EnC (#58728)
tmat Jan 9, 2022
2ea8e8c
Offer to generate parameterless constructor for structs to fix CS8983…
davidwengier Jan 9, 2022
f6396be
Don't crash when default namespace isn't a valid name (#58704)
davidwengier Jan 10, 2022
8bce827
Cleanup old workaround for arcadesdk (#45105)
kzu Jan 10, 2022
fe53cd1
Remove IntelliCodeCompletionOptions (#58748)
tmat Jan 10, 2022
acfd9b0
Merge remote-tracking branch 'upstream/main' into merges/main-to-main…
Cosifne Jan 10, 2022
09af9e4
Synthesize delegate types for lambdas with parameter types or return …
cston Jan 10, 2022
f51c1b2
SpillSequenceSpiller.Spill - ensure sequences under ref assignments a…
AlekseyTs Jan 10, 2022
d16a9bb
Merge pull request #58703 from dotnet/merges/release/dev17.1-vs-deps-…
dotnet-bot Jan 10, 2022
e39fa72
Localized file check-in by OneLocBuild Task: Build definition ID 327:…
dotnet-bot Jan 10, 2022
c19fb4e
Localized file check-in by OneLocBuild Task: Build definition ID 327:…
dotnet-bot Jan 10, 2022
f3c7b8c
Localized file check-in by OneLocBuild Task: Build definition ID 327:…
dotnet-bot Jan 10, 2022
1a1b589
Localized file check-in by OneLocBuild Task: Build definition ID 327:…
dotnet-bot Jan 10, 2022
a78db7b
Merge pull request #58729 from dotnet/merges/main-to-main-vs-deps
dotnet-bot Jan 10, 2022
ef7b79b
Merge remote-tracking branch 'upstream/main' into gen-override-type-c…
CyrusNajmabadi Jan 10, 2022
04ae332
Fix code
CyrusNajmabadi Jan 10, 2022
fddd6d0
Get things building
CyrusNajmabadi Jan 10, 2022
7a6923a
Fix tests
CyrusNajmabadi Jan 10, 2022
86d6fdb
Merge pull request #58756 from dotnet/merges/release/dev17.1-vs-deps-…
dotnet-bot Jan 10, 2022
bb9955c
Merge pull request #58753 from dotnet/locfiles/63e9d652-7348-421f-a33…
Jan 10, 2022
24ef0f3
Move CSharp/Test/Emit/Attributes to Emit2 (#58754)
cston Jan 10, 2022
defd263
Update CSharpUseTupleSwapCodeFixProvider for top-level statements
sharwell Jan 10, 2022
bcc2112
Avoid cyclic references during incremental project update
sharwell Jan 7, 2022
3eccd08
Update language feature status (#58758)
jaredpar Jan 11, 2022
2a7bd86
Merge pull request #58450 from sharwell/proximity-expressions
sharwell Jan 11, 2022
679e37e
Merge pull request #58763 from dotnet/merges/main-to-main-vs-deps
dotnet-bot Jan 11, 2022
fb78249
Merge pull request #58766 from dotnet/merges/main-to-main-vs-deps
dotnet-bot Jan 11, 2022
a7976c5
Merge pull request #58770 from dotnet/merges/release/dev17.1-vs-deps-…
dotnet-bot Jan 11, 2022
6d9b18c
UPdate test
CyrusNajmabadi Jan 11, 2022
0613817
Fix comment
CyrusNajmabadi Jan 11, 2022
8bb17db
Remove unused resource string (#58772)
alrz Jan 11, 2022
26393a4
Unify logic and add tests
CyrusNajmabadi Jan 11, 2022
6b0d35d
Merge pull request #53318 from Youssef1313/gen-override-type-constraint
CyrusNajmabadi Jan 11, 2022
349d9cc
Update src/Compilers/CSharp/Portable/Parser/LanguageParser.cs
CyrusNajmabadi Jan 11, 2022
d54432d
Merge pull request #58760 from sharwell/top-level-swap
sharwell Jan 11, 2022
acdabcb
REvert __arglist changes
CyrusNajmabadi Jan 11, 2022
6b4fb1e
REvert __arglist changes
CyrusNajmabadi Jan 11, 2022
f5819e8
Fix merge conflict
CyrusNajmabadi Jan 11, 2022
7ee9280
Additional #line span directive tests (#58761)
cston Jan 11, 2022
59c9b29
IDE code generator service refactoring (#58244)
tmat Jan 11, 2022
12be03b
Merge pull request #58690 from CyrusNajmabadi/lambdaDefaultValue
CyrusNajmabadi Jan 11, 2022
825c331
Merge remote-tracking branch 'upstream/main' into merges/main-to-main…
Cosifne Jan 11, 2022
f29f937
Use ReadOnlySpan properties over array fields (#56845)
NewellClark Jan 11, 2022
cbf032c
Merge pull request #58781 from dotnet/merges/main-to-main-vs-deps
dotnet-bot Jan 11, 2022
4c9591c
Add test showing case no longer repros
CyrusNajmabadi Jan 11, 2022
2eab822
Revert "Implement GetTypesByMetadataName (#58366)" (#58784)
333fred Jan 11, 2022
7c60002
Parameter null-checking analyzer and fixer (#58182)
RikkiGibson Jan 12, 2022
d34406e
Remove OptionSet and Workspace from TypeScript and F# Inline Rename i…
tmat Jan 12, 2022
96b3058
Make IOperation.ChildOperations public (#52923)
333fred Jan 12, 2022
9a1c752
Merge pull request #58591 from mavasani/HandleGlobalConfig
mavasani Jan 12, 2022
029be87
Merge pull request #58789 from dotnet/dev/shech/main-vs-deps-to-main
Cosifne Jan 12, 2022
6511d3a
Merge pull request #58792 from dotnet/merges/release/dev17.1-to-main
dotnet-bot Jan 12, 2022
3ba71c0
Merge pull request #58793 from dotnet/merges/release/dev17.1-to-relea…
dotnet-bot Jan 12, 2022
7f10360
Change the package feeds and remove the main-vs-deps channel
Cosifne Jan 12, 2022
76c4bbd
Fix failure to hook up TODO processing in-process
sharwell Jan 12, 2022
db732a1
Merge pull request #58460 from mavasani/Issue55541
mavasani Jan 12, 2022
310bb96
Merge pull request #58797 from sharwell/todo-in-proc
sharwell Jan 12, 2022
5b84a8f
Trigger global operation notification during solution close
mavasani Jan 12, 2022
1b30a3b
Null annotate ParameterSymbol and derived (#58700)
jaredpar Jan 12, 2022
2fd9f81
Remove RecoverableTreeLengthThreshold option (#58786)
tmat Jan 12, 2022
40ac01b
Merge pull request #58801 from Cosifne/dev/shech/remove-main-vs-deps
Cosifne Jan 12, 2022
8e3d62a
Rename and share CompilerAnalyzerConfigOptions (#58579)
tmat Jan 12, 2022
74934d2
Fix metadata references declaration (#58059)
chsienki Jan 12, 2022
88b3ca5
Add additional test case
CyrusNajmabadi Jan 12, 2022
9e0e9a2
Add tests for #37309 and #58472 (#58752)
jcouv Jan 12, 2022
0260c24
Remove contract check to avoid crash (#58675)
tmat Jan 12, 2022
be2ff60
Merge pull request #58791 from CyrusNajmabadi/removeCastTest
CyrusNajmabadi Jan 12, 2022
61e507e
Handle more stack frames (#58769)
ryzngard Jan 13, 2022
ef76bcf
Cache the delegate for static method group conversions. (#58288)
pawchen Jan 13, 2022
b2f50a2
Remove unnecessary lock access setting UIContexts in the workspace
CyrusNajmabadi Jan 13, 2022
773c594
Simplify
CyrusNajmabadi Jan 13, 2022
779a935
Simplify
CyrusNajmabadi Jan 13, 2022
fa5bb8a
Update src/VisualStudio/Core/Def/Implementation/ProjectSystem/VisualS…
CyrusNajmabadi Jan 13, 2022
21e4eb2
Remove unnecessary assert
CyrusNajmabadi Jan 13, 2022
3c81f9e
Merge branch 'noLock' of https://github.com/CyrusNajmabadi/roslyn int…
CyrusNajmabadi Jan 13, 2022
57bfca2
Merge pull request #58815 from dotnet/merges/release/dev17.1-to-main
dotnet-bot Jan 13, 2022
cc0d213
Merge pull request #58816 from dotnet/merges/release/dev17.1-to-relea…
dotnet-bot Jan 13, 2022
3604514
Merge pull request #58818 from CyrusNajmabadi/noLock
CyrusNajmabadi Jan 13, 2022
775af69
Reduce Stack Trace Explorer automatic open behavior scope (#58819)
ryzngard Jan 13, 2022
fa9926d
Handle synthesized delegates without refKinds (#58802)
davidwengier Jan 13, 2022
990a3dd
Merge pull request #58805 from mavasani/SolutionClose
mavasani Jan 13, 2022
5fe579d
Fix nrt annotations and impl in syntaxfacts
CyrusNajmabadi Jan 13, 2022
18721c7
Capture information to help track down a crash seen in the wild.
CyrusNajmabadi Jan 13, 2022
6e10cd5
Remove contract calls
CyrusNajmabadi Jan 13, 2022
f7bea7f
Avoid setting MICROSOFT_DIASYMREADER_NATIVE_ env variables in tests (…
jcouv Jan 13, 2022
19bbd47
Merge pull request #58829 from CyrusNajmabadi/nrtAnnotations
CyrusNajmabadi Jan 13, 2022
456baf2
[main] Update dependencies from dotnet/arcade (#58635)
dotnet-maestro[bot] Jan 13, 2022
0cf8be3
Update the insertion instruction
Cosifne Jan 13, 2022
0ff0e59
Do not return empty nodes from teh CodeRefactoringHelpers
CyrusNajmabadi Jan 13, 2022
56f3044
Update comment
CyrusNajmabadi Jan 13, 2022
a20b4e2
Revert
CyrusNajmabadi Jan 13, 2022
2abc7bb
Update VisualStudioCacheVersion
Cosifne Jan 13, 2022
fa8a029
Merge pull request #58842 from Cosifne/dev/shech/updateConfig
Cosifne Jan 13, 2022
940a7ea
Add VSTypeScriptFormattingService to external access (#58817)
tmat Jan 13, 2022
5d9a1d9
Allow configurable behavior
CyrusNajmabadi Jan 13, 2022
c4e40c5
Improve tests for argument completion with semicolon insertion
sharwell Jan 13, 2022
0bbc3c2
Enable test which is already passing
sharwell Jan 13, 2022
083d712
Merge pull request #58847 from dotnet/merges/release/dev17.1-vs-deps-…
dotnet-bot Jan 13, 2022
f3013fd
Revert "Revert "Implement GetTypesByMetadataName (#58366)" (#58784)" …
333fred Jan 13, 2022
b7b363d
Fix
CyrusNajmabadi Jan 13, 2022
1dd33bb
Merge pull request #58850 from sharwell/single-arg
sharwell Jan 13, 2022
03adb3a
Merge pull request #53049 from sharwell/out-var-provider
sharwell Jan 14, 2022
325c3b2
Expand support for context variables
sharwell Apr 30, 2021
9a69692
Perform progression search in two phases. (#58785)
CyrusNajmabadi Jan 14, 2022
dca8ab3
Support 'this' and 'Me' as context variables
sharwell Jan 14, 2022
a43f1c8
Add GlassTestsHotReloadService external access (#58456)
davidwengier Jan 14, 2022
ea49588
Merge pull request #58830 from CyrusNajmabadi/captureInfo
CyrusNajmabadi Jan 14, 2022
9a963de
Merge pull request #58852 from Cosifne/dev/shech/UpdateVersions
Cosifne Jan 14, 2022
71d5b9e
Merge pull request #58720 from sharwell/avoid-cycles
sharwell Jan 14, 2022
cd89d6f
Update dependencies from https://github.com/dotnet/arcade build 20220…
dotnet-maestro[bot] Jan 14, 2022
0d16b5b
Clarify breaking change requirement for constructor in 'struct' with …
cston Jan 14, 2022
b13f587
Add "Utf8 String Literals" to the feature list (#58851)
AlekseyTs Jan 14, 2022
95c7400
Allow patch releases of the SDK to be used
jmarolf Jan 14, 2022
9318267
Change tfm to net46
Cosifne Jan 14, 2022
29c6915
Remove formatting suppression for tuple syntax (#58810)
jcouv Jan 14, 2022
62420a0
Clone source from mirror for DartLab integration tests
JoeRobich Jan 14, 2022
471dbca
Avoid unnecessary array creation (#58821)
RikkiGibson Jan 14, 2022
d2c45de
Merge pull request #58865 from jmarolf/infrastructure/allow-roll-forw…
jmarolf Jan 14, 2022
5a943b1
Merge pull request #53068 from sharwell/context-variables
sharwell Jan 14, 2022
abc7438
Merge pull request #58204 from Cosifne/dev/shech/FixIntegrationTest
Cosifne Jan 14, 2022
1a5c819
[main] Update dependencies from dotnet/roslyn (#58423)
dotnet-maestro[bot] Jan 15, 2022
d1383e7
Steps to investigate CI flakiness with async-streams tests (#58864)
jcouv Jan 15, 2022
d567c5c
Initial analyzer
CyrusNajmabadi Jan 15, 2022
4ed7e99
Add fixer
CyrusNajmabadi Jan 15, 2022
6d13666
Update tests
CyrusNajmabadi Jan 15, 2022
2b5f270
Tweak tests
CyrusNajmabadi Jan 15, 2022
591e899
Formatter options refactoring - step 1 (#58807)
tmat Jan 15, 2022
6a6798c
Fixed
CyrusNajmabadi Jan 15, 2022
e8f7581
Add tests
CyrusNajmabadi Jan 15, 2022
a5cb30b
Add tests
CyrusNajmabadi Jan 15, 2022
3135be2
Add tests
CyrusNajmabadi Jan 15, 2022
ed72724
Add tests
CyrusNajmabadi Jan 15, 2022
28f73b2
Fade correct spans
CyrusNajmabadi Jan 15, 2022
f2d9a5c
Add option to control this feature.
CyrusNajmabadi Jan 15, 2022
2cc6d9f
Add test
CyrusNajmabadi Jan 15, 2022
e9d5ce7
Update src/Features/CSharp/Portable/RemoveUnnecessaryLambdaExpression…
CyrusNajmabadi Jan 15, 2022
469086a
Update src/Compilers/Test/Core/Traits/Traits.cs
CyrusNajmabadi Jan 15, 2022
56305c6
NRT
CyrusNajmabadi Jan 15, 2022
9f735e8
Merge branch 'simplifyLambda' of https://github.com/CyrusNajmabadi/ro…
CyrusNajmabadi Jan 15, 2022
849e576
Add option
CyrusNajmabadi Jan 15, 2022
0875216
Add automation object
CyrusNajmabadi Jan 15, 2022
fbf79ae
Fix issue with generics
CyrusNajmabadi Jan 15, 2022
1f39dfd
Make side effect logic more conservative
CyrusNajmabadi Jan 15, 2022
2c15ba3
Fix name
CyrusNajmabadi Jan 15, 2022
dcbfda8
Move syntactic check up
CyrusNajmabadi Jan 15, 2022
07591bb
Move syntactic check up
CyrusNajmabadi Jan 15, 2022
f03db31
Add test
CyrusNajmabadi Jan 15, 2022
70a2a1f
Make sure overloads don't change
CyrusNajmabadi Jan 15, 2022
754b6d7
Extend comment
CyrusNajmabadi Jan 15, 2022
a3505be
Fix test
CyrusNajmabadi Jan 15, 2022
faf4bc5
Fix test
CyrusNajmabadi Jan 15, 2022
c9e01a1
Fix editorconfig
CyrusNajmabadi Jan 15, 2022
aab7951
Fix off by one
CyrusNajmabadi Jan 15, 2022
a38107f
Add Stack Trace Explorer to our searchable options (#58869)
ryzngard Jan 17, 2022
41d21e7
Cherry-Pick 58869 (#58892)
ryzngard Jan 17, 2022
0c0a1de
Make helper
CyrusNajmabadi Jan 17, 2022
767e2d0
Introduce helpers
CyrusNajmabadi Jan 17, 2022
cd68352
Introduce helpers
CyrusNajmabadi Jan 17, 2022
0d27ecd
Usings
CyrusNajmabadi Jan 17, 2022
9d5415a
Update src/Workspaces/SharedUtilitiesAndExtensions/Compiler/CSharp/Ex…
CyrusNajmabadi Jan 17, 2022
049832d
Fix case where we were not removing a removable cast.
CyrusNajmabadi Jan 17, 2022
5a3b0b8
Add tests
CyrusNajmabadi Jan 17, 2022
d5a90e0
Add more tests
CyrusNajmabadi Jan 17, 2022
e99be4a
Consistency
CyrusNajmabadi Jan 17, 2022
4404b01
Simplify
CyrusNajmabadi Jan 17, 2022
5a156a0
Update dependencies from https://github.com/dotnet/roslyn build 20220…
dotnet-maestro[bot] Jan 17, 2022
71c2c5e
Fix 'remove unnecessary paren' case where we weren't removing around …
CyrusNajmabadi Jan 17, 2022
df3db1b
Update src/Workspaces/SharedUtilitiesAndExtensions/Compiler/CSharp/Ex…
CyrusNajmabadi Jan 17, 2022
fbf6d32
NRT
CyrusNajmabadi Jan 17, 2022
174d7fd
Merge branch 'removeUnnecessaryParensSuppression' of https://github.c…
CyrusNajmabadi Jan 17, 2022
5860901
Merge pull request #58894 from dotnet/merges/release/dev17.1-to-relea…
dotnet-bot Jan 18, 2022
3a8d11a
Merge pull request #58901 from CyrusNajmabadi/nullableCastRemovable
CyrusNajmabadi Jan 18, 2022
1fa9ad6
Merge pull request #58903 from CyrusNajmabadi/removeUnnecessaryParens…
CyrusNajmabadi Jan 18, 2022
8fd2cc2
Merge pull request #58896 from CyrusNajmabadi/langVersion
CyrusNajmabadi Jan 18, 2022
925fb7f
Localized file check-in by OneLocBuild Task: Build definition ID 327:…
dotnet-bot Jan 18, 2022
1aab09a
Localized file check-in by OneLocBuild Task: Build definition ID 327:…
dotnet-bot Jan 18, 2022
59fddf2
Localized file check-in by OneLocBuild Task: Build definition ID 327:…
dotnet-bot Jan 18, 2022
8a1ae31
Merge remote-tracking branch 'upstream/main' into simplifyLambda
CyrusNajmabadi Jan 18, 2022
63113e0
Localized file check-in by OneLocBuild Task: Build definition ID 327:…
dotnet-bot Jan 18, 2022
69ec20c
Move to analyzer project
CyrusNajmabadi Jan 18, 2022
7f32e28
Merge pull request #58907 from dotnet/merges/release/dev17.1-vs-deps-…
dotnet-bot Jan 18, 2022
e41ad5b
Show a specialized display for anonymous delegates in C#
CyrusNajmabadi Jan 18, 2022
0112856
Remove dead code
CyrusNajmabadi Jan 18, 2022
d03854f
Remove dead code
CyrusNajmabadi Jan 18, 2022
9868364
NRT
CyrusNajmabadi Jan 18, 2022
984978d
Only show display for child symbol
CyrusNajmabadi Jan 18, 2022
6610b46
Update src/Analyzers/CSharp/Analyzers/RemoveUnnecessaryLambdaExpressi…
CyrusNajmabadi Jan 18, 2022
6e8abca
Update tests
CyrusNajmabadi Jan 18, 2022
db59d5d
Fix comment
CyrusNajmabadi Jan 18, 2022
d3241f9
Merge branch 'simplifyLambda' of https://github.com/CyrusNajmabadi/ro…
CyrusNajmabadi Jan 18, 2022
5fbe868
Add trivia case
CyrusNajmabadi Jan 18, 2022
640b056
Format
CyrusNajmabadi Jan 18, 2022
54f3d61
Unify C# and VB signatures
CyrusNajmabadi Jan 18, 2022
985bcf6
Display using normal lang syntax.
CyrusNajmabadi Jan 18, 2022
c832b9f
Update src/Features/CSharp/Portable/LanguageServices/CSharpStructural…
CyrusNajmabadi Jan 18, 2022
c5cbf2a
Use service
CyrusNajmabadi Jan 18, 2022
e358022
Merge branch 'anonDelDisplay' of https://github.com/CyrusNajmabadi/ro…
CyrusNajmabadi Jan 18, 2022
8c36793
Simplify
CyrusNajmabadi Jan 18, 2022
fc8894e
Add test
CyrusNajmabadi Jan 18, 2022
33ff264
Merge pull request #58875 from CyrusNajmabadi/simplifyLambda
CyrusNajmabadi Jan 18, 2022
fda42e9
Merge remote-tracking branch 'upstream/main' into anonDelDisplay
CyrusNajmabadi Jan 18, 2022
ddefca4
Simplify
CyrusNajmabadi Jan 18, 2022
b74aff4
Fix test
CyrusNajmabadi Jan 18, 2022
ae335c2
Merge pull request #58908 from CyrusNajmabadi/anonDelDisplay
CyrusNajmabadi Jan 18, 2022
50d9f8a
[main] Update dependencies from dotnet/arcade (#58879)
dotnet-maestro[bot] Jan 18, 2022
7df7a3b
Formatting options refactoring - step 2 (#58891)
tmat Jan 18, 2022
497011d
Handle global methods in GetEmbeddedTypeForMember (#58825)
RikkiGibson Jan 18, 2022
d566086
Fix ParameterSyntax.Update to account for '!!' (#58912)
Youssef1313 Jan 18, 2022
14103f7
Fix 'add accessibility' false positive with abstract statics in inter…
Youssef1313 Jan 18, 2022
8ea5c38
Update Language Feature Status.md (#58919)
RikkiGibson Jan 18, 2022
a476220
Merge pull request #58872 from dotnet/dartlab-fix
JoeRobich Jan 18, 2022
6be7f04
Fix emit of param-nullchecking on async methods (#58822)
RikkiGibson Jan 18, 2022
857f506
Merge pull request #58905 from dotnet/locfiles/95b6649e-5641-4cc9-813…
Jan 18, 2022
fefa37c
Merge pull request #58918 from Youssef1313/ide0040-fp
CyrusNajmabadi Jan 18, 2022
a8c25ef
Syntax tree configuration (#58889)
tmat Jan 18, 2022
3ea4f01
Merge pull request #58928 from dotnet/merges/release/dev17.1-vs-deps-…
dotnet-bot Jan 18, 2022
7b6b572
Handle null coalescing assign-to-self scenarios (#58933)
RikkiGibson Jan 19, 2022
259a9e2
Update dependencies from https://github.com/dotnet/arcade build 20220…
dotnet-maestro[bot] Jan 19, 2022
0ada814
Allow 'ref' and 'in' parameters to be null-checked (#58938)
RikkiGibson Jan 19, 2022
12ca3fc
Merge https://github.com/dotnet/roslyn into features/rename_ui_rework
ryzngard Jan 19, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
3 changes: 2 additions & 1 deletion .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"files.associations": {
"**/eng/pipelines/*.yml": "azure-pipelines"
}
},
"omnisharp.defaultLaunchSolution": "Compilers.sln",
}
7 changes: 0 additions & 7 deletions Roslyn.sln
Original file line number Diff line number Diff line change
Expand Up @@ -372,8 +372,6 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.CodeAnalysis.Comp
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Installer.Package", "src\Setup\Installer\Installer.Package.csproj", "{6A68FDF9-24B3-4CB6-A808-96BF50D1BCE5}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.CodeAnalysis.Workspaces.Desktop.UnitTests", "src\Workspaces\DesktopTest\Microsoft.CodeAnalysis.Workspaces.Desktop.UnitTests.csproj", "{23405307-7EFF-4774-8B11-8F5885439761}"
EndProject
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Insertion", "Insertion", "{AFA5F921-0650-45E8-B293-51A0BB89DEA0}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "DevDivInsertionFiles", "src\Setup\DevDivInsertionFiles\DevDivInsertionFiles.csproj", "{6362616E-6A47-48F0-9EE0-27800B306ACB}"
Expand Down Expand Up @@ -1148,10 +1146,6 @@ Global
{6A68FDF9-24B3-4CB6-A808-96BF50D1BCE5}.Debug|Any CPU.Build.0 = Debug|Any CPU
{6A68FDF9-24B3-4CB6-A808-96BF50D1BCE5}.Release|Any CPU.ActiveCfg = Release|Any CPU
{6A68FDF9-24B3-4CB6-A808-96BF50D1BCE5}.Release|Any CPU.Build.0 = Release|Any CPU
{23405307-7EFF-4774-8B11-8F5885439761}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{23405307-7EFF-4774-8B11-8F5885439761}.Debug|Any CPU.Build.0 = Debug|Any CPU
{23405307-7EFF-4774-8B11-8F5885439761}.Release|Any CPU.ActiveCfg = Release|Any CPU
{23405307-7EFF-4774-8B11-8F5885439761}.Release|Any CPU.Build.0 = Release|Any CPU
{6362616E-6A47-48F0-9EE0-27800B306ACB}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{6362616E-6A47-48F0-9EE0-27800B306ACB}.Debug|Any CPU.Build.0 = Debug|Any CPU
{6362616E-6A47-48F0-9EE0-27800B306ACB}.Release|Any CPU.ActiveCfg = Release|Any CPU
Expand Down Expand Up @@ -1479,7 +1473,6 @@ Global
{B9843F65-262E-4F40-A0BC-2CBEF7563A44} = {C52D8057-43AF-40E6-A01B-6CDBB7301985}
{03607817-6800-40B6-BEAA-D6F437CD62B7} = {BE25E872-1667-4649-9D19-96B83E75A44E}
{6A68FDF9-24B3-4CB6-A808-96BF50D1BCE5} = {BE25E872-1667-4649-9D19-96B83E75A44E}
{23405307-7EFF-4774-8B11-8F5885439761} = {55A62CFA-1155-46F1-ADF3-BEEE51B58AB5}
{AFA5F921-0650-45E8-B293-51A0BB89DEA0} = {8DBA5174-B0AA-4561-82B1-A46607697753}
{6362616E-6A47-48F0-9EE0-27800B306ACB} = {AFA5F921-0650-45E8-B293-51A0BB89DEA0}
{8977A560-45C2-4EC2-A849-97335B382C74} = {FD0FAF5F-1DED-485C-99FA-84B97F3A8EEC}
Expand Down
51 changes: 32 additions & 19 deletions azure-pipelines-integration-corehost.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,33 +12,46 @@ trigger:
# Automatic building of all PRs is disabled in the pipeline's trigger page.
# See https://docs.microsoft.com/en-us/azure/devops/pipelines/repos/github?view=azure-devops&tabs=yaml#comment-triggers
pr:
- main
- main-vs-deps
- release/*
- features/*
- demos/*

variables:
- name: XUNIT_LOGS
value: $(Build.SourcesDirectory)\artifacts\log\$(_configuration)
branches:
include:
- main
- main-vs-deps
- release/*
- features/*
- demos/*
paths:
exclude:
- docs/*
- .github/*

jobs:
- job: VS_Integration_CoreHost
- job: VS_Integration_CoreHost_Debug
pool:
name: NetCore1ESPool-Public
demands: ImageOverride -equals $(queueName)
strategy:
maxParallel: 2
matrix:
debug:
_configuration: Debug
release:
_configuration: Release
timeoutInMinutes: 135

variables:
- name: XUNIT_LOGS
value: $(Build.SourcesDirectory)\artifacts\log\Debug
steps:
- template: eng/pipelines/test-integration-job.yml
parameters:
configuration: $(_configuration)
configuration: Debug
oop64bit: true
oopCoreClr: true

- ${{ if ne(variables['Build.Reason'], 'PullRequest') }}:
- job: VS_Integration_CoreHost_Release
pool:
name: NetCore1ESPool-Public
demands: ImageOverride -equals $(queueName)
timeoutInMinutes: 135
variables:
- name: XUNIT_LOGS
value: $(Build.SourcesDirectory)\artifacts\log\Debug
steps:
- template: eng/pipelines/test-integration-job.yml
parameters:
configuration: Release
oop64bit: true
oopCoreClr: true
9 changes: 9 additions & 0 deletions azure-pipelines-integration-dartlab.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Roslyn integration test pipeline for validating against branch builds of VS.

trigger: none # Manual trigger for now
pr: none # Manual trigger for now

resources:
pipelines:
Expand All @@ -15,6 +16,13 @@ resources:
type: git
name: DartLab.Templates
ref: refs/heads/dev/bradwhit/RemoveCheckoutNone
- repository: RoslynMirror
endpoint: dnceng/internal dotnet-roslyn
type: git
name: internal/dotnet-roslyn
ref: $(Build.SourceBranchName)
trigger:
- main

variables:
- name: XUNIT_LOGS
Expand Down Expand Up @@ -54,6 +62,7 @@ stages:
filePath: $(DartLab.Path)\Scripts\VisualStudio\Build\Get-VisualStudioDropName.ps1
arguments: -DropNamePrefix 'Products' -VstsDropUrlsJson '$(Pipeline.Workspace)\VisualStudioBuildUnderTest\BuildArtifacts\VstsDropUrls.json' -OutVariableName 'VisualStudio.BuildUnderTest.ProductsDropName'
deployAndRunTestsStepList:
- checkout: RoslynMirror
- template: eng/pipelines/test-integration-job.yml
parameters:
configuration: $(_configuration)
Expand Down
90 changes: 63 additions & 27 deletions azure-pipelines-integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,41 +8,77 @@ trigger:

# Branches that trigger builds on PR
pr:
- main
- main-vs-deps
- release/*
- features/*
- demos/*

variables:
- name: XUNIT_LOGS
value: $(Build.SourcesDirectory)\artifacts\log\$(_configuration)
branches:
include:
- main
- main-vs-deps
- release/*
- features/*
- demos/*
paths:
exclude:
- docs/*
- .github/*

jobs:
- job: VS_Integration
- ${{ if ne(variables['Build.Reason'], 'PullRequest') }}:
- job: VS_Integration_Debug_32
pool:
name: $(poolName)
demands: ImageOverride -equals $(queueName)
timeoutInMinutes: 135
variables:
- name: XUNIT_LOGS
value: $(Build.SourcesDirectory)\artifacts\log\Debug
steps:
- template: eng/pipelines/test-integration-job.yml
parameters:
configuration: Debug
oop64bit: false
lspEditor: false

- job: VS_Integration_Debug_64
pool:
name: $(poolName)
demands: ImageOverride -equals $(queueName)
strategy:
maxParallel: 4
matrix:
debug_32:
_configuration: Debug
_oop64bit: false
debug_64:
_configuration: Debug
_oop64bit: true
release_32:
_configuration: Release
_oop64bit: false
release_64:
_configuration: Release
_oop64bit: true
timeoutInMinutes: 135
variables:
- name: XUNIT_LOGS
value: $(Build.SourcesDirectory)\artifacts\log\Debug
steps:
- template: eng/pipelines/test-integration-job.yml
parameters:
configuration: Debug
oop64bit: true
lspEditor: false

- job: VS_Integration_Release_32
pool:
name: $(poolName)
demands: ImageOverride -equals $(queueName)
timeoutInMinutes: 135
variables:
- name: XUNIT_LOGS
value: $(Build.SourcesDirectory)\artifacts\log\Release
steps:
- template: eng/pipelines/test-integration-job.yml
parameters:
configuration: $(_configuration)
oop64bit: $(_oop64bit)
configuration: Release
oop64bit: false
lspEditor: false

- ${{ if ne(variables['Build.Reason'], 'PullRequest') }}:
- job: VS_Integration_Release_64
pool:
name: $(poolName)
demands: ImageOverride -equals $(queueName)
timeoutInMinutes: 135
variables:
- name: XUNIT_LOGS
value: $(Build.SourcesDirectory)\artifacts\log\Release
steps:
- template: eng/pipelines/test-integration-job.yml
parameters:
configuration: Release
oop64bit: true
lspEditor: false
8 changes: 4 additions & 4 deletions azure-pipelines-official.yml
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,9 @@ stages:

- stage: build
displayName: Build and Test
pool:
name: NetCore1ESPool-Svc-Internal
demands: ImageOverride -equals Build.Server.Amd64.VS2019

jobs:
- ${{ if eq(variables['Build.SourceBranch'], 'refs/heads/release/dev17.1-vs-deps') }}:
Expand All @@ -81,9 +84,6 @@ stages:
- job: OfficialBuild
displayName: Official Build
timeoutInMinutes: 360
pool:
name: NetCore1ESPool-Internal
demands: ImageOverride -equals Build.Server.Amd64.VS2019

steps:
- powershell: Write-Host "##vso[task.setvariable variable=SourceBranchName]$('$(Build.SourceBranch)'.Substring('refs/heads/'.Length))"
Expand Down Expand Up @@ -296,7 +296,7 @@ stages:
dependsOn:
- OfficialBuild
pool:
vmImage: vs2017-win2016
vmImage: windows-2019

- stage: insert
dependsOn:
Expand Down
18 changes: 12 additions & 6 deletions azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,17 @@ trigger:

# Branches that trigger builds on PR
pr:
- main
- main-vs-deps
- release/*
- features/*
- demos/*
branches:
include:
- main
- main-vs-deps
- release/*
- features/*
- demos/*
paths:
exclude:
- docs/*
- .github/*

# Windows Build and Test Jobs
jobs:
Expand Down Expand Up @@ -149,7 +155,7 @@ jobs:
buildJobName: Build_Unix_Debug
testArtifactName: Transport_Artifacts_Unix_Debug
configuration: Debug
testArguments: --testCoreClr --helixQueueName OSX.1014.Amd64.Open
testArguments: --testCoreClr --helixQueueName OSX.1015.Amd64.Open

- template: eng/common/templates/jobs/source-build.yml

Expand Down
17 changes: 10 additions & 7 deletions docs/Language Feature Status.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,18 +12,21 @@ efforts behind them.
| ------- | ------ | ----- | --------- | -------- | --------- |
| [Newlines in interpolations](https://github.com/dotnet/csharplang/issues/4935) | main | [Merged in 17.1p1](https://github.com/dotnet/roslyn/issues/57154) | [CyrusNajmabadi](https://github.com/CyrusNajmabadi) | [jcouv](https://github.com/jcouv), [chsienki](https://github.com/chsienki) | [CyrusNajmabadi](https://github.com/CyrusNajmabadi) |
| [List patterns](https://github.com/dotnet/csharplang/issues/3435) | [list-patterns](https://github.com/dotnet/roslyn/tree/features/list-patterns) | [Merged in 17.1p2](https://github.com/dotnet/roslyn/issues/51289) | [alrz](https://github.com/alrz) | [jcouv](https://github.com/jcouv), [333fred](https://github.com/333fred) | [333fred](https://github.com/333fred) |
| [Parameter null-checking](https://github.com/dotnet/csharplang/issues/2145) | [param-nullchecking](https://github.com/dotnet/roslyn/tree/features/param-nullchecking) | [In Progress](https://github.com/dotnet/roslyn/issues/36024) | [RikkiGibson](https://github.com/RikkiGibson), [fayrose](https://github.com/fayrose) | [cston](https://github.com/cston), [chsienki](https://github.com/chsienki) | [jaredpar](https://github.com/jaredpar) |
| [Raw string literals](https://github.com/dotnet/csharplang/issues/4304) | [RawStringLiterals](https://github.com/dotnet/roslyn/tree/features/features/RawStringLiterals) | [In Progress](https://github.com/dotnet/roslyn/issues/55306) | [CyrusNajmabadi](https://github.com/CyrusNajmabadi) | [jcouv](https://github.com/jcouv) | [CyrusNajmabadi](https://github.com/CyrusNajmabadi) |
| [Parameter null-checking](https://github.com/dotnet/csharplang/issues/2145) | [param-nullchecking](https://github.com/dotnet/roslyn/tree/features/param-nullchecking) | [Merged in 17.1p3](https://github.com/dotnet/roslyn/issues/36024) | [RikkiGibson](https://github.com/RikkiGibson), [fayrose](https://github.com/fayrose) | [cston](https://github.com/cston), [chsienki](https://github.com/chsienki) | [jaredpar](https://github.com/jaredpar) |
| [Raw string literals](https://github.com/dotnet/csharplang/issues/4304) | [RawStringLiterals](https://github.com/dotnet/roslyn/tree/features/RawStringLiterals) | [In Progress](https://github.com/dotnet/roslyn/issues/55306) | [CyrusNajmabadi](https://github.com/CyrusNajmabadi) | [jcouv](https://github.com/jcouv) | [CyrusNajmabadi](https://github.com/CyrusNajmabadi) |
| [nameof(parameter)](https://github.com/dotnet/csharplang/issues/373) | main | [In Progress](https://github.com/dotnet/roslyn/issues/40524) | [jcouv](https://github.com/jcouv) | TBD | [jcouv](https://github.com/jcouv) |
| [Relax ordering of `ref` and `partial` modifiers](https://github.com/dotnet/csharplang/issues/946) | [ref-partial](https://github.com/dotnet/roslyn/tree/features/ref-partial) | In Progress | [alrz](https://github.com/alrz) | [gafter](https://github.com/gafter) | [jcouv](https://github.com/jcouv) |
| [Generic attributes](https://github.com/dotnet/csharplang/issues/124) | [generic-attributes](https://github.com/dotnet/roslyn/tree/features/generic-attributes) | [Merged into 17.0p4 (preview langver)](https://github.com/dotnet/roslyn/issues/36285) | [AviAvni](https://github.com/AviAvni) | [RikkiGibson](https://github.com/RikkiGibson), [jcouv](https://github.com/jcouv) | [mattwar](https://github.com/mattwar) |
| [Default in deconstruction](https://github.com/dotnet/roslyn/pull/25562) | [decon-default](https://github.com/dotnet/roslyn/tree/features/decon-default) | [Implemented](https://github.com/dotnet/roslyn/issues/25559) | [jcouv](https://github.com/jcouv) | [gafter](https://github.com/gafter) | [jcouv](https://github.com/jcouv) |
| [Semi-auto-properties](https://github.com/dotnet/csharplang/issues/140) | [semi-auto-properties](https://github.com/dotnet/roslyn/tree/features/features/semi-auto-properties) | [In Progress](https://github.com/dotnet/roslyn/issues/57012) | [Youssef1313](https://github.com/Youssef1313) | TBD | [CyrusNajmabadi](https://github.com/CyrusNajmabadi) |
| [Semi-auto-properties](https://github.com/dotnet/csharplang/issues/140) | [semi-auto-props](https://github.com/dotnet/roslyn/tree/features/semi-auto-props) | [In Progress](https://github.com/dotnet/roslyn/issues/57012) | [Youssef1313](https://github.com/Youssef1313) | [333fred](https://github.com/333fred), [RikkiGibson](https://github.com/RikkiGibson) | [CyrusNajmabadi](https://github.com/CyrusNajmabadi) |
| [Required members](https://github.com/dotnet/csharplang/issues/3630) | [required-members](https://github.com/dotnet/roslyn/tree/features/required-members) | [In Progress](https://github.com/dotnet/roslyn/issues/57046) | [333fred](https://github.com/333fred) | [jcouv](https://github.com/jcouv), [RikkiGibson](https://github.com/RikkiGibson) | [333fred](https://github.com/333fred) |
| [Top Level statement attribute specifiers](https://github.com/dotnet/csharplang/issues/5045) | [main-attributes](https://github.com/dotnet/roslyn/tree/features/features/main-attributes) | [In Progress](https://github.com/dotnet/roslyn/issues/57047) | [chsienki](https://github.com/chsienki) | TBD | [jaredpar](https://github.com/jaredpar) |
| [Primary Constructors](https://github.com/dotnet/csharplang/issues/2691) | [primary-constructors](https://github.com/dotnet/roslyn/tree/features/features/primary-constructors) | [In Progress](https://github.com/dotnet/roslyn/issues/57048) | TBD | TBD | [MadsTorgersen](https://github.com/MadsTorgersen) |
| [Params Span<T> + Stackalloc any array type](https://github.com/dotnet/csharplang/issues/1757) | [params-span](https://github.com/dotnet/roslyn/tree/features/features/params-span) | [In Progress](https://github.com/dotnet/roslyn/issues/57049) | [cston](https://github.com/cston) | TBD | [jaredpar](https://github.com/jaredpar) |

| [Top Level statement attribute specifiers](https://github.com/dotnet/csharplang/issues/5045) | [main-attributes](https://github.com/dotnet/roslyn/tree/features/main-attributes) | [In Progress](https://github.com/dotnet/roslyn/issues/57047) | [chsienki](https://github.com/chsienki) | TBD | [jaredpar](https://github.com/jaredpar) |
| [Primary Constructors](https://github.com/dotnet/csharplang/issues/2691) | [primary-constructors](https://github.com/dotnet/roslyn/tree/features/primary-constructors) | [In Progress](https://github.com/dotnet/roslyn/issues/57048) | TBD | TBD | [MadsTorgersen](https://github.com/MadsTorgersen) |
| [Params Span\<T> + Stackalloc any array type](https://github.com/dotnet/csharplang/issues/1757) | [params-span](https://github.com/dotnet/roslyn/tree/features/params-span) | [In Progress](https://github.com/dotnet/roslyn/issues/57049) | [cston](https://github.com/cston) | TBD | [jaredpar](https://github.com/jaredpar) |
| [Cache delegates for static method group](https://github.com/dotnet/roslyn/issues/5835) | main | [In Progress](https://github.com/dotnet/roslyn/pull/58288) | [pawchen](https://github.com/pawchen) | [AlekseyTs](https://github.com/AlekseyTs), [jcouv](https://github.com/jcouv) | [AlekseyTs](https://github.com/AlekseyTs) |
| [Switch on ReadOnlySpan<char>](https://github.com/dotnet/csharplang/issues/1881) | main | [In Progress](https://github.com/dotnet/roslyn/pull/44388) | [YairHalberstadt ](https://github.com/YairHalberstadt) | [cston](https://github.com/cston), [RikkiGibson](https://github.com/RikkiGibson) | [jcouv](https://github.com/jcouv) |
| [nameof accessing instance memebers](https://github.com/dotnet/roslyn/issues/40229) | main | [In Progress](https://github.com/dotnet/roslyn/pull/48754) | [YairHalberstadt ](https://github.com/YairHalberstadt) | [333fred](https://github.com/333fred), [AlekseyTs](https://github.com/AlekseyTs) | [333fred](https://github.com/333fred) |
| [Utf8 String Literals](https://github.com/dotnet/csharplang/issues/184) | [Utf8StringLiterals](https://github.com/dotnet/roslyn/tree/features/Utf8StringLiterals) | [In Progress](https://github.com/dotnet/roslyn/issues/58848) | [AlekseyTs](https://github.com/AlekseyTs) | [cston](https://github.com/cston), [RikkiGibson](https://github.com/RikkiGibson) | [MadsTorgersen](https://github.com/MadsTorgersen) |

# C# 10.0

Expand Down
21 changes: 21 additions & 0 deletions docs/compilers/CSharp/Compiler Breaking Changes - DotNet 6.md
Original file line number Diff line number Diff line change
Expand Up @@ -108,3 +108,24 @@ These are _function_type_conversions_.
}
}
```

4. In Visual Studio 17.1, `struct` type declarations with field initializers must include an explicitly declared constructor. Additionally, all fields must be definitely assigned in `struct` instance constructors that do not have a `: this()` initializer so any previously unassigned fields must be assigned from the added constructor or from field initializers.

For instance, the following results in an error in 17.1:
```csharp
struct S
{
int X = 1; // error: struct with field initializers must include an explicitly declared constructor
int Y;
}
```

The error could be resolved by adding a constructor and assigning the other field.
```csharp
struct S
{
int X = 1;
int Y;
public S() { Y = 0; } // ok
}
```
10 changes: 5 additions & 5 deletions docs/compilers/CSharp/Compiler Breaking Changes - DotNet 7.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,10 @@ Those types can be used with implicit Index indexer and list patterns.
5. Starting with Visual Studio 17.1, format specifiers in interpolated strings can not contain curly braces (either `{` or `}`). In previous versions `{{` was interpreted as an escaped `{` and `}}` was interpreted as an escaped `}` char in the format specifier. Now the first `}` char in a format specifier ends the interpolation, and any `{` char is an error.
https://github.com/dotnet/roslyn/issues/5775

```csharp
using System;
```csharp
using System;

Console.WriteLine($"{{{12:X}}}");
Console.WriteLine($"{{{12:X}}}");

//prints now: "{C}" - not "{X}}"
```
//prints now: "{C}" - not "{X}}"
```
Loading