Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional tests for raw interpolated strings. #59041

Merged
merged 7 commits into from
Jan 26, 2022
Merged

Add additional tests for raw interpolated strings. #59041

merged 7 commits into from
Jan 26, 2022

Conversation

CyrusNajmabadi
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi commented Jan 24, 2022 •
edited by jcouv
Loading

Relates to test plan #55306

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner January 24, 2022 18:37
@jcouv jcouv self-assigned this Jan 24, 2022
jcouv
jcouv reviewed Jan 24, 2022
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done with review pass (iteration 7)

jcouv
jcouv approved these changes Jan 24, 2022
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 7)

@jcouv
Copy link
Member

jcouv commented Jan 24, 2022

@chsienki @dotnet/roslyn-compiler for second review. Thanks

@jcouv jcouv mentioned this pull request Jan 24, 2022
Open
@runfoapp runfoapp bot mentioned this pull request Jan 24, 2022
Closed
@jcouv jcouv changed the title Add additional test for raw interpolated strings. Add additional tests for raw interpolated strings. Jan 26, 2022
@jcouv jcouv merged commit 2ae217b into dotnet:features/RawStringLiterals Jan 26, 2022
@CyrusNajmabadi CyrusNajmabadi deleted the addConstantTest branch January 26, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chsienki chsienki chsienki approved these changes

@jcouv jcouv jcouv approved these changes

@RikkiGibson RikkiGibson RikkiGibson approved these changes

Assignees

@jcouv jcouv

Labels
Area-Compilers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CyrusNajmabadi @jcouv @RikkiGibson @chsienki