Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race in WorkCoordinator when handling document reanalysis #58820

Merged

Conversation

jasonmalinowski
Copy link
Member

@jasonmalinowski jasonmalinowski commented Jan 13, 2022

When we get a request to reanalyze something, we would add that request into a queue; after
a77c37f however we stopped filtering whether the document still existed before passing it around to other parts of the system -- the code here call just GetDocument and check for null. Now we let it pass out and then we get surprised later when we call GetRequiredDocument.

Fixes AB#1431951

@jasonmalinowski jasonmalinowski requested a review from a team as a code owner January 13, 2022 01:05
When we get a request to reanalyze something, we would add that request
into a queue; after a77c37f however
we stopped filtering whether the document still existed before passing
it around to other parts of the system -- the code here call just
GetDocument and check for null. Now we let it pass out and then we
get surprised later when we call GetRequiredDocument.

Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1431951
@jasonmalinowski jasonmalinowski self-assigned this Jan 14, 2022
@jasonmalinowski jasonmalinowski merged commit aba7c2a into dotnet:release/dev17.1 Jan 20, 2022
@jasonmalinowski jasonmalinowski deleted the fix-reanalysis-race branch January 20, 2022 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants