Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for #37309 and #58472 #58752

Merged
merged 2 commits into from
Jan 12, 2022
Merged

Add tests for #37309 and #58472 #58752

merged 2 commits into from
Jan 12, 2022

Conversation

jcouv
Copy link
Member

@jcouv jcouv commented Jan 10, 2022

Closes #37309
Closes #58472

@jcouv jcouv self-assigned this Jan 10, 2022
@jcouv jcouv added the Test Test failures in roslyn-CI label Jan 10, 2022
eng/Versions.props Outdated Show resolved Hide resolved
@jcouv
Copy link
Member Author

jcouv commented Jan 11, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@jcouv jcouv marked this pull request as ready for review January 11, 2022 18:26
@jcouv jcouv requested review from a team as code owners January 11, 2022 18:26
@jcouv jcouv requested review from tmat and removed request for a team January 11, 2022 18:26
@AlekseyTs
Copy link
Contributor

It looks like the title of the PR is misleading. It claims that the PR is a test only change, but in fact:

  • it changes product code
  • it makes some infrastructure changes

I suggest splitting PRs into 3. At least the infrastructure changes should be separated, I think. Also all PRs should have titles that accurately reflect the nature of changes.

@jcouv
Copy link
Member Author

jcouv commented Jan 12, 2022

I don't think the PR contains any meaningful product code or infrastructure change. I'm opportunistically trying to close issues that are low-hanging fruits. Making more PRs seems like just overhead given the tiny size of the change, but that's fine:

#58810
#58808

@jcouv jcouv enabled auto-merge (squash) January 12, 2022 18:48
@jcouv jcouv merged commit 9e0e9a2 into dotnet:main Jan 12, 2022
@ghost ghost added this to the Next milestone Jan 12, 2022
@RikkiGibson RikkiGibson modified the milestones: Next, 17.2.P1 Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Compilers Test Test failures in roslyn-CI
Projects
None yet
4 participants