Remove OptionSet and Workspace from TypeScript and F# Inline Rename interfaces

[tmat]

Replaces TS and F# external interfaces with equivalent abstract classes (with updated signatures) to allow easier modifications in future.
Minor fix in OmniSharpRenamer

F#:
dotnet/fsharp#12527

TypeScript:
https://devdiv.visualstudio.com/DevDiv/_git/TypeScript-VS/pullrequest/370211

[jasonmalinowski]

I get what this PR is doing, but I do wish the Obsolete messages generally pointed to their replacements, or at least to a tracking bug or something that when closed means all of that stuff could be deleted. Otherwise I imagine us leaving a bunch of this around or later being confused what the old stuff is for.

[tmat]

I get what this PR is doing, but I do wish the Obsolete messages generally pointed to their replacements, or at least to a tracking bug or something that when closed means all of that stuff could be deleted. Otherwise I imagine us leaving a bunch of this around or later being confused what the old stuff is for.

I can file a bug: #58442. I don't think adding messages adds any value since I'm already updating TS and F# as well.

[tmat]

@jasonmalinowski Any more feedback?

[jasonmalinowski]

I don't think adding messages adds any value since I'm already updating TS and F# as well.

I'd disagree, simply because we've had a bunch of times where we create a replacement, the consuming side updates, and we then forget to actually do the follow-up. I appreciate the tracking bug but unless it's listing what is actually obsolete it's a huge mess to sort out later if you're either not the original author, or it's been long enough you have to page it back into memory.

[tmat]

. I appreciate the tracking bug but unless it's listing what is actually obsolete it's a huge mess to sort out later if you're either not the original author, or it's been long enough you have to page it back into memory.

The issue links to this PR. It's easy to look at the diff and remove the types that are marked Obsolete here.