Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter null-checking analyzer and fixer #58182

Merged
merged 16 commits into from
Jan 12, 2022
Merged

Parameter null-checking analyzer and fixer #58182

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
746f2e5
Parameter null-checking analyzer and fixer
RikkiGibson Jan 3, 2022
718fa55
Move to new test framework. Various fixes.
RikkiGibson Jan 4, 2022
2dd31c5
support lambdas. other minor feedback items.
RikkiGibson Jan 4, 2022
b3ce666
Use AdditionalLocations for parameter location
RikkiGibson Jan 4, 2022
bdda177
more
RikkiGibson Jan 5, 2022
484d3d4
Fix more tests
RikkiGibson Jan 5, 2022
755a8b7
Merge branch 'main' of github.com:dotnet/roslyn into pnc-fixer
RikkiGibson Jan 5, 2022
96bcd3e
fix
RikkiGibson Jan 5, 2022
553d946
Handle operators and 0-param exception ctor. More tests.
RikkiGibson Jan 7, 2022
31acd9c
Adjust feature config (WIP)
RikkiGibson Jan 7, 2022
c4e1150
Update test (WIP)
RikkiGibson Jan 7, 2022
f961f33
Fix test
RikkiGibson Jan 7, 2022
5a759d7
Handle by-ref parameters
RikkiGibson Jan 7, 2022
d4a1407
Fix base call
RikkiGibson Jan 7, 2022
5b1dcb3
Imitate UseNotPattern and add test
RikkiGibson Jan 8, 2022
46382fa
Address feedback
RikkiGibson Jan 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...rp/Analyzers/UseParameterNullChecking/CSharpUseParameterNullCheckingDiagnosticAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ public CSharpUseParameterNullCheckingDiagnosticAnalyzer()
: base(IDEDiagnosticIds.UseParameterNullCheckingId,
EnforceOnBuildValues.UseParameterNullChecking,
CSharpCodeStyleOptions.PreferParameterNullChecking,
CSharpAnalyzersResources.Use_parameter_null_checking,
RikkiGibson marked this conversation as resolved.
Show resolved Hide resolved
LanguageNames.CSharp,
new LocalizableResourceString(nameof(AnalyzersResources.Null_check_can_be_simplified), AnalyzersResources.ResourceManager, typeof(AnalyzersResources)))
{
}
Expand Down