Update codestyle analyzer #55646
Merged
Update codestyle analyzer #55646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @sharwell |
333fred
reviewed
Aug 16, 2021
| @@ -101,7 +101,7 @@ internal override void GenerateMethodBodyStatements(SyntheticBoundNodeFactory F, | |||
|
|
|||
| internal static bool IsCopyConstructor(Symbol member) | |||
| { | |||
| if (member is MethodSymbol { ContainingType: { IsRecordStruct: false }, MethodKind: MethodKind.Constructor } method) | |||
| if (member is MethodSymbol { ContainingType.IsRecordStruct: false, MethodKind: MethodKind.Constructor } method) | |||
There was a problem hiding this comment.
We can use extended property patterns in the compiler now?
There was a problem hiding this comment.
Yes, since around the time dev17p3 became public we've made it a requirement for working on roslyn, so we can use C# 10 features :-)
sharwell
reviewed
Aug 17, 2021
| @@ -30,7 +30,7 @@ | |||
| <RoslynDiagnosticsNugetPackageVersion>3.3.3-beta1.21105.3</RoslynDiagnosticsNugetPackageVersion> | |||
| <MicrosoftCodeAnalysisNetAnalyzersVersion>6.0.0-rc1.21366.2</MicrosoftCodeAnalysisNetAnalyzersVersion> | |||
| <MicrosoftCodeAnalysisTestingVersion>1.1.0-beta1.21322.2</MicrosoftCodeAnalysisTestingVersion> | |||
| <CodeStyleAnalyzerVersion>3.10.0</CodeStyleAnalyzerVersion> | |||
| <CodeStyleAnalyzerVersion>4.0.0-3.final</CodeStyleAnalyzerVersion> | |||
There was a problem hiding this comment.
💡 The version of dotnet-format in dotnet-tools.json should be updated to match this version at the same time. @JoeRobich can help identify the matching version number.
sharwell
approved these changes
Aug 17, 2021
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.