Fix interpolated string refactoring to work for Console.Write* #55521
Conversation
...ertToInterpolatedString/AbstractConvertPlaceholderToInterpolatedStringRefactoringProvider.cs
Outdated
Show resolved
Hide resolved
| .OfType<IMethodSymbol>() | ||
| .Where(ShouldIncludeFormatMethod) | ||
| .ToImmutableArray(); | ||
| var consoleType = semanticModel.Compilation.GetTypeByMetadataName(typeof(Console).FullName); |
There was a problem hiding this comment.
Should we eventually support all methods mentioned in composite formatting?
There was a problem hiding this comment.
maybe. The intention of this PR was to open that possibility up easily without adding them, since the original issue and design only mentioned console.
There was a problem hiding this comment.
AppendFormat is fun because you would want it to substitute with Append($"")
There was a problem hiding this comment.
yea, I'm really thinking there should be some sort of abstraction here for all of that...
There was a problem hiding this comment.
Updated included ones in this PR
...atures/CSharpTest/ConvertToInterpolatedString/ConvertPlaceholderToInterpolatedStringTests.cs
Outdated
Show resolved
Hide resolved
...atures/CSharpTest/ConvertToInterpolatedString/ConvertPlaceholderToInterpolatedStringTests.cs
Outdated
Show resolved
Hide resolved
...atures/CSharpTest/ConvertToInterpolatedString/ConvertPlaceholderToInterpolatedStringTests.cs
Outdated
Show resolved
Hide resolved
...atures/CSharpTest/ConvertToInterpolatedString/ConvertPlaceholderToInterpolatedStringTests.cs
Outdated
Show resolved
Hide resolved
| .OfType<IMethodSymbol>() | ||
| .Where(ShouldIncludeFormatMethod) | ||
| .ToImmutableArray(); | ||
| var consoleType = semanticModel.Compilation.GetTypeByMetadataName(typeof(Console).FullName); |
There was a problem hiding this comment.
AppendFormat is fun because you would want it to substitute with Append($"")
...ertToInterpolatedString/AbstractConvertPlaceholderToInterpolatedStringRefactoringProvider.cs
Outdated
Show resolved
Hide resolved
| @@ -35,18 +35,22 @@ public override async Task ComputeRefactoringsAsync(CodeRefactoringContext conte | |||
| var semanticModel = await document.GetRequiredSemanticModelAsync(cancellationToken).ConfigureAwait(false); | |||
|
|
|||
| var stringType = semanticModel.Compilation.GetSpecialType(SpecialType.System_String); | |||
| if (stringType == null) | |||
|
|
|||
| if (stringType is null) | |||
There was a problem hiding this comment.
This if condition is unreachable. Only GetTypeByMetadataName can return null. For special type if it doesn't exist, the compiler returns an error symbol.
There was a problem hiding this comment.
I see. Looks like the initial code was wrong then. Fixing
...ertToInterpolatedString/AbstractConvertPlaceholderToInterpolatedStringRefactoringProvider.cs
Outdated
Show resolved
Hide resolved
...ertToInterpolatedString/AbstractConvertPlaceholderToInterpolatedStringRefactoringProvider.cs
Outdated
Show resolved
Hide resolved
...atures/CSharpTest/ConvertToInterpolatedString/ConvertPlaceholderToInterpolatedStringTests.cs
Show resolved
Hide resolved
ghost
added this to the 
Fixes #55053