Use NuGetPackageResolver in InteractiveHost #5356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
cston
commented
Sep 19, 2015
cston
commented
- Use resolver in InteractiveHost.Service
- Change reference syntax to #r "nuget:name/version"
- Use local cache only for resolving packages
| @@ -46,24 +39,26 @@ internal sealed class RuntimeMetadataReferenceResolver : MetadataReferenceResolv | |||
|
|
|||
| public override ImmutableArray<PortableExecutableReference> ResolveReference(string reference, string baseFilePath, MetadataReferenceProperties properties) | |||
| { | |||
| if (PathResolver != null && PathUtilities.IsFilePath(reference)) | |||
| if (PackageResolver != null) | |||
There was a problem hiding this comment.
I think it would be clearer to parse up front and then try either nuget resolution or file resolution. Consider adding a TryParse method that returns a refined string to be passed to ResolveNuGetPackage.
|
Can one of the admins approve this PR test or whitelist this user? ('@dotnet-bot add to whitelist' to whitelist, '@dotnet-bot okay to test' to accept for PR, '@dotnet-bot test this please' to retest. Case sensitive). |
|
@dotnet-bot retest this please |
|
Just curious; Why is the package version required? |
|
@khellang The package version should be optional. We'll remove the version requirement in a separate PR. |
|
Agreed. Awesome 👍 |
cston
added a commit
that referenced
this pull request
Sep 23, 2015
Use NuGetPackageResolver in InteractiveHost - Use resolver in InteractiveHost.Service - Change reference syntax to #r "nuget:name/version" - Use local cache only for resolving packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.