Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OutVariableArgumentProvider for 'out' parameters #53049

Merged
merged 4 commits into from
Jan 14, 2022

Conversation

sharwell
Copy link
Member

@sharwell sharwell commented Apr 30, 2021

Statistics for Compilers.sln before this change:

Solution:
  Total:     4307883
  Correct:   391422
  Incorrect: 3916461
  Missing:   0

After this change:

Solution:
  Total:     4307883
  Correct:   399915 (+8493)
  Incorrect: 3907968 (-8493)
  Missing:   0

@sharwell sharwell requested a review from a team as a code owner April 30, 2021 04:24
@sharwell sharwell marked this pull request as draft April 30, 2021 04:25
@sharwell sharwell changed the base branch from main to release/dev16.11 April 30, 2021 15:05
@sharwell sharwell changed the base branch from release/dev16.11 to main July 2, 2021 22:46
@sharwell sharwell enabled auto-merge July 2, 2021 22:46
@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

});
}

var symbol = symbols.Single();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the filtering above guaranteed to limit us to a single result? or would an exception here mean the test should be rewritten to remove ambiguity?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still possible to construct a test that the framework doesn't support. We'd have to modify it at that time to support the specifics of the new test.

@sharwell sharwell merged commit 03adb3a into dotnet:main Jan 14, 2022
@ghost ghost added this to the Next milestone Jan 14, 2022
@sharwell sharwell deleted the out-var-provider branch January 14, 2022 00:21
@RikkiGibson RikkiGibson modified the milestones: Next, 17.2.P1 Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants