Merge master to release/dev16.9-preview1 #47927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now support understanding the calling convention types specified in UnmanagedCallersOnlyAttribute when performing overload resolution on an address of a method group. For the purposes of such resolution, we use the rules from the function pointers spec https://github.com/dotnet/csharplang/blob/master/proposals/csharp-9.0/function-pointers.md#systemruntimeinteropservicesunmanagedcallersonlyattribute.
* Simplified the handling for bad expressions in UnmanagedCallersOnly data, it is now ignored. * Refactored UnmanagedCallersOnlyAttributeData to be a method with a forceComplete parameter, for better behavior with PEMethodSymbol. * Added and tweaked a couple of tests.
…l test refactorings.
…ly and regular the same, and simplify the comparisons.
…entions supplied to the CallConvTypes array.
* Simplified convention type checking * Fixed stackoverflow in attribute constructor overload resolution * Added more loop tests.
…ions Implement UnmanagedCallersOnly conversions support
…rFix Sort the code fix action for UnusedValueCodeFixProvider
…and Interlocked (#47523)
|
Hello @dotnet-bot! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 12 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
This was referenced Sep 23, 2020
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatically generated pull request from master into release/dev16.9-preview1.
Once all conflicts are resolved and all the tests pass, you are free to merge the pull request. 🐯
Troubleshooting conflicts
Identify authors of changes which introduced merge conflicts
Scroll to the bottom, then for each file containing conflicts copy its path into the following searches:
Usually the most recent change to a file between the two branches is considered to have introduced the conflicts, but sometimes it will be necessary to look for the conflicting lines and check the blame in each branch. Generally the author whose change introduced the conflicts should pull down this PR, fix the conflicts locally, then push up a commit resolving the conflicts.
Resolve merge conflicts using your local repo
Sometimes merge conflicts may be present on GitHub but merging locally will work without conflicts. This is due to differences between the merge algorithm used in local git versus the one used by GitHub.
git fetch --all git checkout merges/master-to-release/dev16.9-preview1 git reset --hard upstream/release/dev16.9-preview1 git merge upstream/master # Fix merge conflicts git commit git push upstream merges/master-to-release/dev16.9-preview1 --force