Solution asset cache refactoring #46948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmat
force-pushed
the
SolutionAssetCache
branch
from
b7f42d1 to
092e5c1
Compare
tmat
commented
Aug 24, 2020
| /// <summary> | ||
| /// Create solution for given checksum from base solution | ||
| /// </summary> | ||
| private readonly struct SolutionCreator |
There was a problem hiding this comment.
private readonly struct SolutionCreator [](start = 8, length = 39)
Moved to a nested struct.
CyrusNajmabadi
approved these changes
Aug 26, 2020
tmat
force-pushed
the
SolutionAssetCache
branch
from
092e5c1 to
d928709
Compare
tmat
force-pushed
the
SolutionAssetCache
branch
from
d928709 to
c5715b6
Compare
ghost
added this to the
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Aug 27, 2020
…-only-errors * upstream/master: (236 commits) Fix bug when "End statement" is used in single-line if (dotnet#47062) Solution asset cache refactoring (dotnet#46948) add specific tests to validate behavior between keys and snapshots Extract into separate files rename parameters rename parameters rename parameters rename parameters Add CancellationToken parameters to SyntaxTreeOptionsProvider Reuse nullable override checks for delegate conversions (dotnet#46953) Introduce warning for multiple entry points (sync + async) (dotnet#46832) Switch from throwing NotImplementedException and return E_NOTIMPL Delete Building for Core CLR.md (dotnet#47146) Adjust PrintMembers to avoid boxing and avoid extra space (dotnet#47095) Track asynchronous operation in InProcLanguageServer Use Task.FromCanceled where appropriate Apply suggestions from code review Address feedback Expose ParseOptions on generator context (dotnet#46919) Remove redundant statement in added tests ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor AssetStorage on the server side.