Add support to disable analyzers via MSBuild property 'RunAnalyzers' #46471
Conversation
Fixes dotnet#40926 This support was added to `Microsoft.CodeAnalysis.targets` (ships with VS) in VS2019 16.5: https://docs.microsoft.com/en-us/visualstudio/code-quality/disable-code-analysis?view=vs-2019. However, the MSBuild property is not respected from 'dotnet' builds where this targets file is not imported (see dotnet#40926 (comment) for details). This change moves the disable analyzers logic down to `Microsoft.Managed.Core.targets` so it is respected for all builds.
|
@dotnet/roslyn-compiler for an additional review. |
1 similar comment
|
@dotnet/roslyn-compiler for an additional review. |
|
@chsienki can u take a look at this since Rikki is OOF today? |
|
|
||
| <!-- Remove all analyzers for non-design time builds. --> | ||
| <ItemGroup Condition="'$(_RunAnalyzers)' == 'false' and '$(_IsAnyDesignTimeBuild)' != 'true'"> | ||
| <Analyzer Remove="@(Analyzer)" /> |
There was a problem hiding this comment.
My Concern with this is the same as #46300
Because we pass generators in via analyzers, builds can be potentially broken by this now. I think before it was fine: an analyzer can only take a successful build -> failed, but generators are very much the other way.
There was a problem hiding this comment.
Hmm we already have shipping functionality in VS based on such properties: https://docs.microsoft.com/en-us/visualstudio/code-quality/disable-code-analysis?view=vs-2019. This is done by this targets file that ships with MSBuild in VS. This change is just ensuring the existing functionality works fine from dotnet builds.
There was a problem hiding this comment.
Right, I don't think its necessarily an analyzer problem.
I think there is a separate issue here though, that saying 'Don't run analyzers' is also going to prevent generators from running.
There was a problem hiding this comment.
Thanks, seems like we can take couple of paths forward here:
- Abandon this PR and instead have a separate command line compiler flag, say
skipAnalyzersso the build skips analyzer execution, but not generators. - Keep the approach in this PR, and break the
Analyzercollection into two separate collectionsAnalyzerandGenerator, so this change will not affect generators. However, if user ships both analyzers and generators in the same assembly, then they will be affected.
|
Closing in favor of #46669 |
Fixes #40926
This support was added to
Microsoft.CodeAnalysis.targets(ships with MSBuild in VS) in VS2019 16.5:https://docs.microsoft.com/visualstudio/code-quality/disable-code-analysis?view=vs-2019.
However, the MSBuild property is not respected for 'dotnet' builds where this targets file is not imported (see #40926 (comment) for details). This change moves the disable analyzers logic down to
Microsoft.Managed.Core.targetsso it is respected for all builds.