Enable FormattingAnalyzer #31142
Merged
Enable FormattingAnalyzer #31142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharwell
added
the
PR For Personal Review Only
| // diagnostics have been reported (not necessarily on this thread). | ||
| done: | ||
| // Don't return until we've seen all of the CompletionParts. This ensures all | ||
| // diagnostics have been reported (not necessarily on this thread). |
There was a problem hiding this comment.
I agree, this appears to be a bug.
src/Compilers/CSharp/Portable/Lowering/LocalRewriter/LocalRewriter_Conversion.cs
Outdated
Show resolved
Hide resolved
| @@ -1122,7 +1122,7 @@ static S1 MayWrap(ref int arg) | |||
| } | |||
| "; | |||
| CreateCompilationWithMscorlibAndSpan(text).VerifyDiagnostics( | |||
| // no diagnostics expected | |||
| // no diagnostics expected | |||
There was a problem hiding this comment.
this change is minor, but seems also undesirable.
There was a problem hiding this comment.
probably not a big deal though.
There was a problem hiding this comment.
I agree this appears to be a bug.
This comment has been minimized.
This comment has been minimized.
sharwell
force-pushed
the
formatting-analyzer
branch
from
ec5d28b to
a979978
Compare
src/Compilers/Core/Portable/InternalUtilities/TextKeyedCache.cs
Outdated
Show resolved
Hide resolved
src/Compilers/CSharp/Portable/Lowering/LocalRewriter/LocalRewriter_Call.cs
Outdated
Show resolved
Hide resolved
Commit looks good! :) |
sharwell
force-pushed
the
formatting-analyzer
branch
from
a979978 to
33199ac
Compare
src/Workspaces/Core/Portable/EmbeddedLanguages/RegularExpressions/RegexLexer.cs
Outdated
Show resolved
Hide resolved
|
Went through all the change. LGTM. Thanks for breaking it out into pieces. It made reviewing much easier! |
CyrusNajmabadi
approved these changes
Nov 14, 2018
sharwell
commented
Nov 26, 2018
src/Compilers/Core/Portable/InternalUtilities/TextKeyedCache.cs
Outdated
Show resolved
Hide resolved
sharwell
force-pushed
the
formatting-analyzer
branch
2 times, most recently
from
a016af6 to
187686d
Compare
sharwell
removed
the
PR For Personal Review Only
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
sharwell
force-pushed
the
formatting-analyzer
branch
from
187686d to
b22a9ac
Compare
sharwell
commented
Dec 6, 2018
build/scripts/tools.ps1
Outdated
| @@ -413,7 +413,7 @@ function MSBuild() { | |||
| $cmdArgs = "$($buildTool.Command) /m /nologo /clp:Summary /v:$verbosity /nr:$nodeReuse" | |||
|
|
|||
| if ($warnAsError) { | |||
| $cmdArgs += " /warnaserror /p:TreatWarningsAsErrors=true" | |||
| $cmdArgs += " /p:TreatWarningsAsErrors=true" | |||
There was a problem hiding this comment.
@tmat I had to make this change or the build would ignore my request for <WarningsNotAsErrors>.
This comment has been minimized.
This comment has been minimized.
jaredpar
reviewed
Dec 6, 2018
jaredpar
requested changes
Dec 6, 2018
sharwell
force-pushed
the
formatting-analyzer
branch
from
b22a9ac to
25a63ee
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This changes the code style analyzers so that they only execute on the build correctness leg. This means that even in the face of style errors our build will be covered via this leg but we will also get test run output as the other legs won't hit the style errors.
|
Pretty sure this commit should do the trick |
jaredpar
approved these changes
Dec 14, 2018
|
@jinujoseph for approval |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recommend reviewing by individual commit.
Reviewers should pay particular attention to all commits that are not the large and automated application of formatting changes.