Fix up our build badges #31052
Merged
Fix up our build badges #31052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet/roslyn-infrastructure please take a look |
tmeschter
approved these changes
Nov 9, 2018
agocke
approved these changes
Nov 9, 2018
| 'dev16.0-preview2-vs-deps') | ||
|
|
||
| function Get-AzureBadge($branchName, $jobName, $configName) { | ||
| $template = "[]" |
There was a problem hiding this comment.
It's not really a template if you substitute inline
There was a problem hiding this comment.
There's nothing that says a template has to be configurable just that it's a pattern https://www.merriam-webster.com/dictionary/template
👅
|
Thanks! |
dpoeschl
reviewed
Nov 9, 2018
| ### Desktop Unit Tests | ||
| |Branch|Debug x86|Debug x64|Release x86|Release x64|Spanish| | ||
| |:--:|:--:|:--:|:--:|:--:|:--:| | ||
| **master**|[](https://dev.azure.com/dnceng/public/_build/latest?definitionId=15&branchname=master)|[](https://dev.azure.com/dnceng/public/_build/latest?definitionId=15&branchname=master)|[](https://dev.azure.com/dnceng/public/_build/latest?definitionId=15&branchname=master)|[](https://dev.azure.com/dnceng/public/_build/latest?definitionId=15&branchname=master)|[](https://dev.azure.com/dnceng/public/_build/latest?definitionId=15&branchname=master)|[](https://dev.azure.com/dnceng/public/_build/latest?definitionId=15&branchname=master)|[](https://dev.azure.com/dnceng/public/_build/latest?definitionId=15&branchname=master)| |
There was a problem hiding this comment.
These links all go to the same place, which lists the problems across all builds in that roslyn-CI run with no immediate indication of what's what. So when you click on an individual queue here you might think the problems you then see are for that queue, but they may or may not be. If we can't make per-queue links (I don't see how but haven't tried hard), consider adding &view=logs to the end of the link URLs so you can see the overview and click the queue you were interested in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #30827