Gracefully handle project systems not giving us a file path #30889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously didn't throw if a project system refused to give us a file path for the project file itself. In my refactoring, this accidentally switched over to a Marshal.ThrowExceptionForHR, which is now causing us to crash on at least Visual Studio Tools for Office projects. Put this back for now. Ultimately, after this "fix" we're back to the behavior described in dotnet/rosyn#30429: we won't crash, but we won't have a project file for the project.
Pilchie
approved these changes
Nov 1, 2018
genlu
approved these changes
Nov 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously didn't throw if a project system refused to give us a file path for the project file itself. In my refactoring, this accidentally switched over to a Marshal.ThrowExceptionForHR, which is now causing us to crash on at least Visual Studio Tools for Office projects. Put this back for now.
Ultimately, after this "fix" we're back to the behavior described in dotnet/rosyn#30429: we won't crash, but we won't have a project file for the project.