Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that the compilers produce double.NaN values in IEEE canonical form. #30587

Merged
merged 3 commits into from
Oct 29, 2018
Merged

Ensure that the compilers produce double.NaN values in IEEE canonical form. #30587

merged 3 commits into from
Oct 29, 2018

Conversation

gafter
Copy link
Member

@gafter gafter commented Oct 18, 2018

Fixes #30439

@gafter gafter added Bug Area-Compilers Concept-Determinism The issue involves our ability to support determinism in binaries and PDBs created at build time. labels Oct 18, 2018
@gafter gafter added this to the 16.0.P1 milestone Oct 18, 2018
@gafter gafter self-assigned this Oct 18, 2018
@gafter gafter requested a review from a team as a code owner October 18, 2018 16:58
jaredpar
jaredpar requested changes Oct 18, 2018
View reviewed changes
Copy link
Member

@jaredpar jaredpar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@gafter
Copy link
Member Author

gafter commented Oct 18, 2018

I believe I have addressed all comments. @tannergooding @jaredpar Do you have any further comments?

jaredpar
jaredpar approved these changes Oct 18, 2018
View reviewed changes
Copy link
Member

@jaredpar jaredpar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@gafter
Copy link
Member Author

gafter commented Oct 22, 2018

test ubuntu_16_debug_prtest please

@gafter gafter closed this Oct 22, 2018
@gafter gafter reopened this Oct 22, 2018
@gafter
Copy link
Member Author

gafter commented Oct 22, 2018

test ubuntu_16_debug_prtest please

@gafter gafter closed this Oct 22, 2018
@gafter gafter reopened this Oct 22, 2018
@gafter
Copy link
Member Author

gafter commented Oct 22, 2018

PR testing appears to be broken.

@gafter
Copy link
Member Author

gafter commented Oct 22, 2018

Looks like something in the testing infrastructure is broken. ubuntu_16_debug_prtest fails because

14:49:53 Shutting down Razor build server (process 58421)...
14:49:53 Razor build server (process 58421) failed to shut down: The shutdown command failed: The application to execute does not exist: '/mnt/j/workspace/dotnet_cli/release_2.2.1xx/release_linux_x64_prtest/.nuget/packages/microsoft.aspnetcore.razor.design/2.2.0-preview3-35497/tools/rzc.dll'

I'm going to retarget master since it is getting late for preview 1.

@gafter gafter changed the base branch from dev16.0.x to master October 22, 2018 23:47
@jaredpar
Copy link
Member

Everything is green now. Are we good to merge?

@gafter gafter merged commit a26da66 into dotnet:master Oct 29, 2018
@lewurm lewurm mentioned this pull request Oct 30, 2018
Closed
wachulski added a commit to wachulski/roslyn that referenced this pull request Oct 31, 2018
@wachulski
Merge remote-tracking branch 'origin/master' into fix/27866/else-with…
4b51565 
…out-if-error-message

* origin/master: (1712 commits)
  User-defined operator checks should ignore differences in tuple member names (dotnet#30774)
  Attempted fix for correctly reporting error CS1069 when using implicit namespaces (dotnet#30244)
  Invert the binding order of InitializerExpressions and CreationExpressions (dotnet#30805)
  Use Arcade bootstrapping scripts (dotnet#30498)
  Ensure that the compilers produce double.NaN values in IEEE canonical form. (dotnet#30587)
  Remove properties set in BeforeCommonTargets.targets
  Fix publishing of dependent projects
  Contributing page: reference Unix build instructions
  Delete 0
  Propagate values from AbstractProject to VisualStudioProjectCreationInfo
  Fix publishing nuget info of dev16.0.x-vs-deps branch
  Revert "Add a SetProperty API for CPS to passing msbuild properties"
  Validate generic arguments in `using static` directives (dotnet#30737)
  Correct 15.9 publish data
  Enable test.
  Do not inject attribute types into .Net modules.
  Add a SetProperty API for CPS to passing msbuild properties
  Revert "add beta2 suffix to dev16 branch"
  Fix references
  Remove commit sha from package versions
  ...
@lewurm lewurm mentioned this pull request Jul 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cston cston cston approved these changes

@tannergooding tannergooding tannergooding approved these changes

@jaredpar jaredpar jaredpar approved these changes

Assignees

@gafter gafter

Labels
Area-Compilers Bug Concept-Determinism The issue involves our ability to support determinism in binaries and PDBs created at build time.
Projects
None yet
Milestone
16.0.P1
Development

Successfully merging this pull request may close these issues.
4 participants
@gafter @jaredpar @tannergooding @cston