Pulling "default" literal feature into master branch #18717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: src/Compilers/CSharp/Portable/Binder/Semantics/Conversions/ConversionKind.cs src/Compilers/CSharp/Portable/Binder/Semantics/Conversions/ConversionKindExtensions.cs src/Compilers/CSharp/Portable/Errors/MessageID.cs src/Compilers/CSharp/Portable/Parser/LanguageParser.cs src/Compilers/CSharp/Portable/PublicAPI.Unshipped.txt src/Compilers/CSharp/Portable/Syntax/Syntax.xml src/Compilers/CSharp/Portable/Syntax/SyntaxKind.cs src/Compilers/CSharp/Test/Semantic/CSharpCompilerSemanticTest.csproj src/Compilers/CSharp/Test/Syntax/Parsing/ExpressionParsingTests.cs src/Test/Utilities/Desktop/TestResource.resx src/Test/Utilities/Shared/Traits/CompilerFeature.cs
dotnet#16425) Conflicts: src/Compilers/CSharp/Portable/Binder/Binder_Expressions.cs src/Compilers/CSharp/Portable/Binder/Binder_Query.cs src/Compilers/CSharp/Portable/Compiler/MethodCompiler.cs src/Compilers/CSharp/Portable/Errors/ErrorCode.cs
…net#17205) Conflicts: src/Compilers/CSharp/Portable/Binder/Binder_Conversions.cs src/Compilers/CSharp/Portable/Binder/Semantics/Conversions/ConversionKind.cs src/Compilers/CSharp/Portable/Binder/Semantics/Conversions/ConversionKindExtensions.cs src/Compilers/CSharp/Portable/CodeGen/EmitExpression.cs
Conflicts: src/Compilers/CSharp/Portable/CSharpResources.resx src/Compilers/CSharp/Portable/Errors/ErrorCode.cs src/Compilers/CSharp/Test/Syntax/Parsing/ExpressionParsingTests.cs
pull request dotnet#17925 from jcouv/merge-master
Conflicts: src/Compilers/CSharp/Portable/CSharpResources.resx src/Compilers/CSharp/Portable/Errors/ErrorCode.cs
Conflicts: src/Compilers/CSharp/Portable/PublicAPI.Unshipped.txt
Conflicts: src/Compilers/CSharp/Portable/CSharpResources.resx
|
Approved as 15.3 planned feature. |
|
@dotnet-bot test windows_debug_vs-integration_prtest please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customer scenario
Customers can now omit the type in
default(T). The literaldefaultwill infer its type, just likenulldoes, with the difference thatdefaultworks both with struct and ref types.Bugs this fixes:
This C# 7.1 language new feature implements https://github.com/dotnet/csharplang/blob/master/proposals/target-typed-default.md
Risk
Performance impact
Low. This is a small feature.
@MeiChin-Tsai for ask mode approval. This is a new feature. All the PRs to the feature branch had two reviews and we also went through the new test process with @cston (test plan #18595)
FYI @dotnet/roslyn-compiler