Add test for null-coalescing operator on nullable tuples with names #16857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcouv
added
Area-Compilers
Feature - Tuples
VSadov
reviewed
Jan 31, 2017
|
|
||
| var x5 = nab != null ? nab : nac; // (a, )? | ||
|
|
||
| var x6 = nab ?? (a: 1, c: 3); // (a, b) |
There was a problem hiding this comment.
Try adding
var x6double = nab ?? (a: 1.1, c: 3); // (a, c)
There should be no warnings in this case.
|
LGTM |
|
@jcouv Should we add similar test(s) for VB? |
|
Yes, Will do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test-only change.
Verifies #16825
@VSadov @dotnet/roslyn-compiler for review