Splitting binding code for Decontsruct into separate file #11983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet/roslyn-compiler team for review. This is just splitting the Deconstruct binding code into a separate file, and updating a couple comments. |
|
@VSadov Could I get a sign-off on this refactoring (splitting code into separate file)? |
|
LGTM |
|
Merged with a single approval since there is no new code introduced. |
| result.WasCompilerGenerated = true; | ||
| diagnostics.AddRange(bag); | ||
|
|
||
| if (bag.HasAnyErrors()) |
There was a problem hiding this comment.
I missed this during the previous review. It might be inappropriate to use HasAnyErrors here. There are at least two reasons for that:
- It resolves lazy diagnostics, which could create circularity problems in certain contexts.
- Lazy errors shouldn't really fail the binding. An example would be an obsolete Deconstruct method. Yes, it is an error to use it, but that shouldn't prevent us from recording the actual binding information and continuing to the next level. I.e. we shouldn't complain that we couldn't find a suitable method.
Consider using HasAnyResolvedErrors instead and adding a test with an obsolete Deconstruct method.
There was a problem hiding this comment.
Thanks. I took a note in #11299 to fix this.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.