Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate type not offered for complex pattern type. #9089

Closed
CyrusNajmabadi opened this issue Feb 23, 2016 · 3 comments
Closed

Generate type not offered for complex pattern type. #9089

CyrusNajmabadi opened this issue Feb 23, 2016 · 3 comments
Assignees
@CyrusNajmabadi
Labels
2 - Ready Area-Compilers Bug Feature - Pattern Matching Pattern Matching
Milestone
2.0 (Preview 1)

Comments

@CyrusNajmabadi
Copy link
Member 

            if (x is Blah { X is int i })
            {
            }

No code action offered to generate a type for 'Blah'.
@CyrusNajmabadi CyrusNajmabadi mentioned this issue Feb 23, 2016
Closed
@DustinCampbell DustinCampbell added this to the 2.0 (Preview) milestone Feb 24, 2016
@gafter
Copy link
Member

gafter commented Feb 29, 2016

OK, I rebuilt and restarted the VS from the future branch, and it now works, offering to generate the type.

@gafter gafter closed this as completed Feb 29, 2016
@gafter gafter added Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented and removed 2 - Ready Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented labels Feb 29, 2016
@gafter gafter reopened this Mar 1, 2016
@gafter
Copy link
Member

gafter commented Mar 1, 2016

No, it does not work when the patterns feature is enabled.

@gafter gafter assigned CyrusNajmabadi and unassigned gafter Mar 1, 2016
CyrusNajmabadi added a commit that referenced this issue Apr 6, 2016
@CyrusNajmabadi
Merge pull request #9362 from CyrusNajmabadi/generateTypePatterns
969474f 
Support 'generate type' on complex patterns.

Fixes #9089
@CyrusNajmabadi
Copy link
Member Author

Fixed with 38f8b8f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CyrusNajmabadi CyrusNajmabadi

Labels
2 - Ready Area-Compilers Bug Feature - Pattern Matching Pattern Matching
Projects
None yet
Milestone
2.0 (Preview 1)
Development

No branches or pull requests
3 participants
@DustinCampbell @gafter @CyrusNajmabadi