Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EndToEndDeterminismTest should use Temp.CreateDirectory #6233

Closed
TyOverby opened this issue Oct 22, 2015 · 7 comments
Closed

EndToEndDeterminismTest should use Temp.CreateDirectory #6233

TyOverby opened this issue Oct 22, 2015 · 7 comments
Assignees
Labels
Area-Compilers Bug Test Test failures in roslyn-CI
Milestone

Comments

@TyOverby
Copy link
Contributor

This causes us to leave many temporary directories strewn about at the end of tests like VBCSCompilerTests/CompilerServerTests.cs

@TyOverby
Copy link
Contributor Author

@agocke

@tmat
Copy link
Member

tmat commented Oct 22, 2015

TempRoot should be disposed by xunit calling the test class Dispose.

@agocke
Copy link
Member

agocke commented Oct 22, 2015

@tmat Iff you use the one in TestBase, right? This makes sense -- @TyOverby's PR had the creation of a temp root outside TestBase and I couldn't figure out how it was supposed to be disposed. It looks like you're never supposed to create your own TempRoot, is that right?

@gafter gafter added Bug Area-Compilers Test Test failures in roslyn-CI labels Oct 22, 2015
@gafter gafter added this to the 1.2 milestone Oct 22, 2015
@tmat
Copy link
Member

tmat commented Oct 22, 2015

You can. You just need to make sure to dispose it. If the test class implements IDisposable xunit disposes it. Why don't we inherit from TestBase though?

@agocke
Copy link
Member

agocke commented Oct 22, 2015

@tmat In this case I think the class can just inherit from TestBase.

@agocke
Copy link
Member

agocke commented Oct 22, 2015

@TyOverby I think this bug can be resolved by just changing

to call Temp.CreateDirectory()

@TyOverby
Copy link
Contributor Author

@agocke That looks about right. I'll make that change later.

@TyOverby TyOverby self-assigned this Oct 22, 2015
@agocke agocke changed the title TempRoot does not have a finalize method EndToEndDeterminismTest should use Temp.CreateDirectory Nov 4, 2015
TyOverby added a commit to TyOverby/roslyn that referenced this issue Dec 14, 2015
TyOverby added a commit to TyOverby/roslyn that referenced this issue Jan 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Compilers Bug Test Test failures in roslyn-CI
Projects
None yet
Development

No branches or pull requests

4 participants