-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EndToEndDeterminismTest should use Temp.CreateDirectory
#6233
Comments
TempRoot should be disposed by xunit calling the test class Dispose. |
You can. You just need to make sure to dispose it. If the test class implements IDisposable xunit disposes it. Why don't we inherit from TestBase though? |
@tmat In this case I think the class can just inherit from TestBase. |
@TyOverby I think this bug can be resolved by just changing
Temp.CreateDirectory()
|
@agocke That looks about right. I'll make that change later. |
Temp.CreateDirectory
This causes us to leave many temporary directories strewn about at the end of tests like VBCSCompilerTests/CompilerServerTests.cs
The text was updated successfully, but these errors were encountered: