Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Prepare-TempDir function from build.ps1 #49486

Closed
RikkiGibson opened this issue Nov 19, 2020 · 1 comment
Closed

Remove Prepare-TempDir function from build.ps1 #49486

RikkiGibson opened this issue Nov 19, 2020 · 1 comment
Assignees
Milestone

Comments

@RikkiGibson
Copy link
Contributor

roslyn/eng/build.ps1

Lines 573 to 583 in 198c614

function Prepare-TempDir() {
$env:TEMP=$TempDir
$env:TMP=$TempDir
Copy-Item (Join-Path $RepoRoot "src\Workspaces\MSBuildTest\Resources\.editorconfig") $TempDir
Copy-Item (Join-Path $RepoRoot "src\Workspaces\MSBuildTest\Resources\global.json") $TempDir
Copy-Item (Join-Path $RepoRoot "src\Workspaces\MSBuildTest\Resources\Directory.Build.props") $TempDir
Copy-Item (Join-Path $RepoRoot "src\Workspaces\MSBuildTest\Resources\Directory.Build.targets") $TempDir
Copy-Item (Join-Path $RepoRoot "src\Workspaces\MSBuildTest\Resources\Directory.Build.rsp") $TempDir
Copy-Item (Join-Path $RepoRoot "src\Workspaces\MSBuildTest\Resources\NuGet.Config") $TempDir
}

This function seems to exist to get the test environment in a good state for CI runs. We should move this logic out of this script and into the appropriate tests as a pre-test step.

This introduced complexity when removing the restore and checkout steps from our test runs. When this issue is addressed, the code in MinimizeUtil which copies the resources into the test payload should also be deleted.

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Nov 19, 2020
@RikkiGibson
Copy link
Contributor Author

Tagging @jasonmalinowski @jaredpar

@jinujoseph jinujoseph removed the untriaged Issues and PRs which have not yet been triaged by a lead label Dec 9, 2020
@jinujoseph jinujoseph added this to the Backlog milestone Dec 9, 2020
@jasonmalinowski jasonmalinowski self-assigned this Feb 23, 2024
jasonmalinowski added a commit to jasonmalinowski/roslyn that referenced this issue Feb 23, 2024
The tests that need to set things up like this should just be ensuring
this state directly, since there's no guarantee that this would have
ran before many types of tests run.

Fixes dotnet#49486
jasonmalinowski added a commit to jasonmalinowski/roslyn that referenced this issue Feb 24, 2024
The tests that need to set things up like this should just be ensuring
this state directly, since there's no guarantee that this would have
ran before many types of tests run.

Fixes dotnet#49486
jasonmalinowski added a commit to jasonmalinowski/roslyn that referenced this issue Feb 24, 2024
The tests that need to set things up like this should just be ensuring
this state directly, since there's no guarantee that this would have
ran before many types of tests run.

Fixes dotnet#49486
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants