Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

t is null with LangVersion 7 should produce a diagnostic #34678

Closed
jcouv opened this issue Apr 2, 2019 · 2 comments
Closed

t is null with LangVersion 7 should produce a diagnostic #34678

jcouv opened this issue Apr 2, 2019 · 2 comments
Assignees
@gafter
Labels
3 - Working Area-Compilers Bug Feature - Pattern Matching Pattern Matching
Milestone
16.1

Comments

@jcouv
Copy link
Member

jcouv commented Apr 2, 2019 •
edited
Loading

The issue was reported by @varobc in https://github.com/dotnet/cli/issues/11020
FYI @peterhuene @333fred

When this is fixed (likely in 16.1), this should be documented as a breaking change, albeit a short-lived one.
@jcouv jcouv added this to the 16.1 milestone Apr 2, 2019
@jcouv jcouv modified the milestones: 16.1, 16.0 Apr 2, 2019
@gafter
Copy link
Member

gafter commented Apr 2, 2019

See #25995 where this behavior was introduced.

The language feature was championed here: dotnet/csharplang#1284

@gafter
Copy link
Member

gafter commented Apr 2, 2019

t is null should produce a diagnostic when LangVersion is < 8. That diagnostic should indicate that upgrading the LangVersion would make the code compile.

gafter added a commit to gafter/roslyn that referenced this issue Apr 2, 2019
@gafter
t is null with LangVersion 7 should produce a diagnostic
7388c94 
Fixes dotnet#34678
@gafter gafter mentioned this issue Apr 2, 2019
Merged
gafter pushed a commit that referenced this issue Apr 6, 2019
t is null with LangVersion 7 should produce a diagnostic (#34695)
336c376 
Fixes #34678
@gafter gafter mentioned this issue Apr 9, 2019
Closed
@RikkiGibson RikkiGibson mentioned this issue Apr 10, 2019
Closed
@333fred 333fred mentioned this issue May 15, 2019
Open
5 tasks
@RikkiGibson RikkiGibson mentioned this issue Sep 10, 2019
Closed
@Youssef1313 Youssef1313 mentioned this issue Nov 30, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gafter gafter

Labels
3 - Working Area-Compilers Bug Feature - Pattern Matching Pattern Matching
Projects
None yet
Milestone
16.1
Development

No branches or pull requests
2 participants
@gafter @jcouv