Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add embedded source support for Windows PDBs #13707

Closed
nguerrera opened this issue Sep 9, 2016 · 4 comments · Fixed by #21391
Closed

Add embedded source support for Windows PDBs #13707

nguerrera opened this issue Sep 9, 2016 · 4 comments · Fixed by #21391
Assignees
@tmat
Labels
Area-Interactive Interactive-Debugging
Milestone
15.5

Comments

@nguerrera
Copy link
Contributor

The design tracked by #12625 already accounts for Windows PDBs, but an issue where diasymreader can write but not read back embedded sources for documents with no sequence points.

This is to track getting the diasymreader issue resolved and #13138 unblocked.

Tracking it separately to mark the most pressing need (in portable PDBs) done for 2.0 Preview 5.
@nguerrera nguerrera added this to the 2.0 (RC) milestone Sep 9, 2016
@nguerrera nguerrera self-assigned this Sep 9, 2016
This was referenced Sep 9, 2016
Closed
Closed
Closed
@nguerrera nguerrera modified the milestones: 2.1, 2.0 (RC) Sep 21, 2016
@nguerrera
Copy link
Contributor Author

Moving to 2.1 since there's too much project system work going on to get this in for RC. cc @srivatsn

This was referenced Nov 18, 2016
Closed
Open
@tmat tmat modified the milestones: Unknown, 15.1 Mar 9, 2017
@nguerrera
Copy link
Contributor Author

nguerrera commented Apr 26, 2017 •
edited
Loading

Closed stale WIP PR #13138, but it is the starting point for when this ultimately gets picked back up.

@tmat tmat assigned tmat and unassigned nguerrera Aug 3, 2017
@tmat
Copy link
Member

tmat commented Aug 3, 2017

@nguerrera I'm gonna finish this. Are "documents with no sequence points" the only issue you know of?

@tmat tmat modified the milestones: 15.5, Unknown Aug 3, 2017
@nguerrera
Copy link
Contributor Author

@tmat Yes. That was the only known issue.

@tmat tmat mentioned this issue Aug 8, 2017
Merged
@leonard-thieu leonard-thieu mentioned this issue Dec 28, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmat tmat

Labels
Area-Interactive Interactive-Debugging
Projects
None yet
Milestone
15.5
2 participants
@tmat @nguerrera