Skip to content
This repository has been archived by the owner on Apr 16, 2020. It is now read-only.

Support embedding source files in Windows PDB #297

Closed
leonard-thieu opened this issue Dec 28, 2017 · 5 comments
Closed

Support embedding source files in Windows PDB #297

leonard-thieu opened this issue Dec 28, 2017 · 5 comments

Comments

@leonard-thieu
Copy link
Contributor

Roslyn compilers can support embedding source files in Windows PDBs starting in v2.6.0 (VS v15.5). Could support for this be added to SourceLink.Embed.AllSourceFiles?
@leonard-thieu
Copy link
Contributor Author

Closing because I ended up with a solution sufficient for my needs.

@jnm2
Copy link
Contributor

jnm2 commented Jan 19, 2018

@ctaggart Can we make this happen?

@ctaggart
Copy link
Owner

@jnm2 Go for it. Probably just drop of the condition: https://github.com/ctaggart/SourceLink/blob/master/SourceLink.Embed.AllSourceFiles/SourceLink.Embed.AllSourceFiles.targets#L3

@ctaggart ctaggart reopened this Jan 19, 2018
@jnm2
Copy link
Contributor

jnm2 commented Jan 23, 2018

What I didn't see was that an EmbedAllSources MSBuild property is in Roslyn master as of a couple weeks ago (https://github.com/dotnet/roslyn/pull/23656 🎉), so I suppose the NuGet packages will be obsolete in VS 15.6? What's your plan for SourceLink.Embed.AllSourceFiles?

@ctaggart
Copy link
Owner

We can retire the nupkg for SourceLink 3.0 now that the feature will be built in.
dotnet/roslyn#19127

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ctaggart @leonard-thieu @jnm2