Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSharpExtensions.GetDeclaredSymbol changes #12747

Closed
jaredpar opened this issue Jul 26, 2016 · 1 comment
Closed

CSharpExtensions.GetDeclaredSymbol changes #12747

jaredpar opened this issue Jul 26, 2016 · 1 comment
Assignees
@gafter
Labels
Area-Compilers Bug Concept-API This issue involves adding, removing, clarification, or modification of an API. Feature - Pattern Matching Pattern Matching Feature - Tuples Tuples Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Milestone
2.0 (Preview 5)

Comments

@jaredpar
Copy link
Member

From API Review

The API CSharpExtensions.GetDeclaredSymbol needs the following changes:

  • Return ILocalSymbol instead of ISymbol
@jaredpar jaredpar added Bug Concept-API This issue involves adding, removing, clarification, or modification of an API. Area-Compilers labels Jul 26, 2016
@jaredpar jaredpar added this to the 2.0 (RC) milestone Jul 26, 2016
@gafter
Copy link
Member

gafter commented Jul 26, 2016 •
edited
Loading

This is for the version for pattern variables.

We may need a version for deconstruction declarations (returns ISymbol so it can handle deconstruction into queries and fields later).

gafter added a commit to gafter/roslyn that referenced this issue Aug 3, 2016
@gafter
Overhaul syntax model for deconstruction decl
df48ec6 
Also update the out var syntax node to use the newly introduced
VariableComponent so it can be extended in the future to allow `out *`
or `out var (x, y)` etc without requiring any further changes to the
syntax model.
Fixes dotnet#12747, dotnet#12664, dotnet#12588, dotnet#1503
@gafter gafter mentioned this issue Aug 3, 2016
Merged
@gafter gafter added 4 - In Review A fix for the issue is submitted for review. and removed 3 - Working labels Aug 3, 2016
@gafter gafter added Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented and removed 4 - In Review A fix for the issue is submitted for review. labels Aug 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gafter gafter

Labels
Area-Compilers Bug Concept-API This issue involves adding, removing, clarification, or modification of an API. Feature - Pattern Matching Pattern Matching Feature - Tuples Tuples Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Projects
None yet
Milestone
2.0 (Preview 5)
Development

No branches or pull requests
2 participants
@jaredpar @gafter