Deal with booleans that had been converted to integers in the cloud

Previously, we would return the incorrectly typed data and then we'd
crash downstream of that. Now we'll be more robust, dealing with this
legacy data. Other type mismatches will also be thrown out now.

Fixes #15214.

src/VisualStudio/Core/Def/Implementation/Options/RoamingVisualStudioProfileOptionPersister.cs

@@ -132,9 +132,28 @@ public bool TryFetch(OptionKey optionKey, out object value)
                 }
                 else
                 {
-                    value = optionKey.Option.DefaultValue;
+                    value = null;
+                    return false;
                 }
             }
+            else if (optionKey.Option.Type == typeof(bool) && value is int intValue)
+            {
+                // TypeScript used to store some booleans as integers. We now handle them properly for legacy sync scenarios.
+                value = intValue != 0;
+                return true;
+            }
+            else if (optionKey.Option.Type == typeof(bool) && value is long longValue)
+            {
+                // TypeScript used to store some booleans as integers. We now handle them properly for legacy sync scenarios.
+                value = longValue != 0;
+                return true;
+            }
+            else if (value != null && optionKey.Option.Type != value.GetType())
+            {
+                // We got something back different than we expected, so fail to deserialize
+                value = null;
+                return false;
+            }
 
             return true;
         }
@@ -189,4 +208,4 @@ public bool TryPersist(OptionKey optionKey, object value)
             return true;
         }
     }
-}
+}