Made EE tolerant to ByRef types.

Ideally EE should not encounter ByRef types, but for now I just make EE resilient if it sees them
dotnet · Feb 18, 2016 · 6d02c04 · 6d02c04
1 parent a2ec4cc
commit 6d02c04
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/src/ExpressionEvaluator/Core/Source/ResultProvider/Helpers/TypeAndCustomInfo.cs b/src/ExpressionEvaluator/Core/Source/ResultProvider/Helpers/TypeAndCustomInfo.cs
@@ -21,7 +21,21 @@ public TypeAndCustomInfo(DkmClrType type, DkmClrCustomTypeInfo info = null)
 
         public Type Type
         {
-            get { return (ClrType == null) ? null : ClrType.GetLmrType(); }
+            get
+            {
+                var t = ClrType?.GetLmrType();
+
+                //TODO: Sometimes we get byref types here when dealing with ref-returning members.
+                //      That probably should not happen.
+                //      For now we will just unwrap unexpected byrefs
+                if (t?.IsByRef == true)
+                {
+                    t = t.GetElementType();
+                    Debug.Assert(!t.IsByRef, "double byref type?");
+                }
+
+                return t;
+            }
         }
     }
 }
diff --git a/src/ExpressionEvaluator/Core/Test/ResultProvider/Debugger/MemberInfo/TypeImpl.cs b/src/ExpressionEvaluator/Core/Test/ResultProvider/Debugger/MemberInfo/TypeImpl.cs
@@ -406,7 +406,7 @@ protected override bool IsArrayImpl()
 
         protected override bool IsByRefImpl()
         {
-            throw new NotImplementedException();
+            return Type.IsByRef;
         }
 
         protected override bool IsCOMObjectImpl()