Enable publishing in VMR #7233
Enable publishing in VMR #7233
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7233 +/- ##
========================================
Coverage 96.46% 96.47%
========================================
Files 1427 1436 +9
Lines 341805 342787 +982
Branches 11259 11289 +30
========================================
+ Hits 329725 330693 +968
- Misses 9231 9239 +8
- Partials 2849 2855 +6 |
eng/Publishing.props
Outdated
|
|
||
| <ItemGroup> | ||
| <_PackagesToPublish Remove="@(_PackagesToPublish)" /> | ||
| <_PackagesToPublish Include="$(ArtifactsPackagesDir)**\*.nupkg" UploadPathSegment="Roslyn-analyzers" Condition="'$(DotNetBuildRepo)' == 'true'" /> |
There was a problem hiding this comment.
I'm skeptical any of this is needed. In addition, UploadPathSegment won't do anything.
There was a problem hiding this comment.
This is very similar to the fsharp case: dotnet/fsharp#16838 (comment). Arcade infra won't collect all of the packages as the sub-directories under artifacts/Packages are different than what arcade expects.
There was a problem hiding this comment.
It shouldn't collect everything I think. This will include duplicates of packages (with different branding).
There was a problem hiding this comment.
Old model of harvesting artifacts (RepoManifest.xml) was collecting all of these. Here's are the packages:
artifacts/packages/Release/PreRelease/Microsoft.CodeAnalysis.Analyzers.3.11.0-beta1.final.nupkg
artifacts/packages/Release/PreRelease/Microsoft.CodeAnalysis.AnalyzerUtilities.3.11.0-beta1.final.nupkg
artifacts/packages/Release/PreRelease/Microsoft.CodeAnalysis.NetAnalyzers.9.0.0-preview.final.nupkg
artifacts/packages/Release/PreRelease/Roslyn.Diagnostics.Analyzers.3.11.0-beta1.final.nupkg
artifacts/packages/Release/Release/Microsoft.CodeAnalysis.Analyzers.3.11.0.nupkg
artifacts/packages/Release/Release/Microsoft.CodeAnalysis.AnalyzerUtilities.3.11.0.nupkg
artifacts/packages/Release/Release/Microsoft.CodeAnalysis.NetAnalyzers.9.0.0.nupkg
artifacts/packages/Release/Release/Roslyn.Diagnostics.Analyzers.3.11.0.nupkg
artifacts/packages/Release/Shipping/Microsoft.CodeAnalysis.Analyzers.3.11.0-beta1.24128.1.nupkg
artifacts/packages/Release/Shipping/Microsoft.CodeAnalysis.AnalyzerUtilities.3.11.0-beta1.24128.1.nupkg
artifacts/packages/Release/Shipping/Microsoft.CodeAnalysis.NetAnalyzers.9.0.0-preview.24128.1.nupkg
artifacts/packages/Release/Shipping/Roslyn.Diagnostics.Analyzers.3.11.0-beta1.24128.1.nupkg
No duplication of package names, but I'm unsure of contents and if we need all of them. Linux VMR build did require more than what was harvested by default arcade publishing infra.
I'm doing a local test to see if we can avoid changes in this PR altogether. Same with fsharp changes.
There was a problem hiding this comment.
OK - it appears that none of the other packages are needed from this repo - I'm going to close this PR once I'm done with verification.
There was a problem hiding this comment.
Tried to remove all of these packages and 2nd-stage Linux build failed with missing dependency (package downgrade):
##vso[task.logissue type=error;sourcepath=/src/git/dotnet/src/sdk/src/BuiltInTools/dotnet-watch/dotnet-watch.csproj;linenumber=0;columnnumber=0;code=NU1605;](NETCORE_ENGINEERING_TELEMETRY=Restore) Warning As Error: Detected package downgrade: Microsoft.CodeAnalysis.AnalyzerUtilities from 3.11.0 to 3.11.0-beta1.24128.1. Reference the package directly from the project to select a different version. %0A dotnet-watch -> Microsoft.CodeAnalysis.CSharp.Features 4.10.0-3.24129.7 -> Microsoft.CodeAnalysis.Features 4.10.0-3.24129.7 -> Microsoft.CodeAnalysis.AnalyzerUtilities (>= 3.11.0) %0A dotnet-watch -> Microsoft.CodeAnalysis.CSharp.Features 4.10.0-3.24129.7 -> Microsoft.CodeAnalysis.AnalyzerUtilities (>= 3.11.0-beta1.24128.1)
I am now testing a change to include the following packages, and only in source-only build:
artifacts/packages/Release/Release/Microsoft.CodeAnalysis.Analyzers.3.11.0.nupkg
artifacts/packages/Release/Release/Microsoft.CodeAnalysis.AnalyzerUtilities.3.11.0.nupkg
artifacts/packages/Release/Release/Microsoft.CodeAnalysis.NetAnalyzers.9.0.0.nupkg
artifacts/packages/Release/Release/Roslyn.Diagnostics.Analyzers.3.11.0.nupkg
There was a problem hiding this comment.
Trimmed the publishing to include minimum required packages - f62d4c4
Without these changes, 2nd stage Linux build is failing. This can be evaluated at later time to determine if there is a way to get rid of these additional packages. Linux source-build was requiring all of these packages and more. This is an improvement.
There was a problem hiding this comment.
Added a reference to tracking issue with 109356e
Thanks! |
Fixed with f8fa09b |
|
@dotnet/roslyn-analysis can you please approve and merge this PR? |
| <ItemGroup> | ||
| <ItemsToPushToBlobFeed Include="$(ArtifactsPackagesDir)Release\*.nupkg" | ||
| IsShipping="true" | ||
| UploadPathSegment="Roslyn-analyzers" |
There was a problem hiding this comment.
I don't see Arcade respecting the UploadPathSegment item metadata. Why did you have to set it?
Contributes to dotnet/source-build#4101
Enables publishing in VMR.
This repo creates packages in locations that aren't collected by common publishing infra in arcade. We need to collect them here.