Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update messaging fo the after merge comments #6178

Merged
merged 6 commits into from
Dec 6, 2022
Merged

Update messaging fo the after merge comments #6178

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9a0beb9
Update messaging fo the after merge comments
buyaa-n Sep 22, 2022
2f0a004
Apply suggestions from code review
buyaa-n Sep 29, 2022
0c3175d
Merge conflicts
buyaa-n Oct 3, 2022
f85cfe9
Merge conflict
buyaa-n Oct 3, 2022
f7fdd64
Fix bad merging
buyaa-n Oct 3, 2022
77ca277
Merge conflicts
buyaa-n Dec 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/MicrosoftNetCoreAnalyzersResources.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1981,7 +1981,7 @@
<value>Prefer 'Clear' over 'Fill'</value>
</data>
<data name="PreventNumericIntPtrUIntPtrBehavioralChangesDescription" xml:space="preserve">
<value>Some built in operators added in .NET 7 behave differently than the user defined operatorsi in .NET 6 and below. Some operators that used to throw in unchecked context while overflowing will not throw anymore unless wrapped within checked context, and some operators that not used to throw in checked context now would throw unless wrapped within unchecked context.</value>
<value>Some built in operators added in .NET 7 behave differently when overflowing than did the user defined operators in .NET 6 and below. Some operators that used to throw in an unchecked context now no longer throw unless wrapped within a checked context, and some operators that did not previously throw in a checked context now throw unless wrapped in an unchecked context.</value>
buyaa-n marked this conversation as resolved.
Show resolved Hide resolved
</data>
<data name="PreventNumericIntPtrUIntPtrBehavioralChangesConversionNotThrowMessage" xml:space="preserve">
<value>Starting with .NET 7 the explicit conversion '{0}' will not throw when overflowing in an unchecked context. Wrap the expression with a 'checked' statement to restore the .NET 6 behavior.</value>
Expand All @@ -1990,7 +1990,7 @@
<value>Starting with .NET 7 the operator '{0}' will throw when overflowing in a checked context. Wrap the expression with an 'unchecked' statement to restore the .NET 6 behavior.</value>
</data>
<data name="PreventNumericIntPtrUIntPtrBehavioralChangesTitle" xml:space="preserve">
<value>Prevent from behavioral change</value>
<value>Prevent behavioral change</value>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe better to mention that its related to the behavioral changes in IntPtr/UIntPtr, something like

Suggested change
<value>Prevent behavioral change</value>
<value>Prevent numeric IntPtr/UIntPtr behavioral changes</value>

buyaa-n marked this conversation as resolved.
Show resolved Hide resolved
</data>
<data name="PreventNumericIntPtrUIntPtrBehavioralChangesConversionThrowsMessage" xml:space="preserve">
<value>Starting with .NET 7 the explicit conversion '{0}' will throw when overflowing in a checked context. Wrap the expression with an 'unchecked' statement to restore the .NET 6 behavior.</value>
Expand Down
8 changes: 4 additions & 4 deletions ...tAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.cs.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2118,8 +2118,8 @@
<note />
</trans-unit>
<trans-unit id="PreventNumericIntPtrUIntPtrBehavioralChangesDescription">
<source>Some built in operators added in .NET 7 behave differently than the user defined operatorsi in .NET 6 and below. Some operators that used to throw in unchecked context while overflowing will not throw anymore unless wrapped within checked context, and some operators that not used to throw in checked context now would throw unless wrapped within unchecked context.</source>
<target state="new">Some built in operators added in .NET 7 behave differently than the user defined operatorsi in .NET 6 and below. Some operators that used to throw in unchecked context while overflowing will not throw anymore unless wrapped within checked context, and some operators that not used to throw in checked context now would throw unless wrapped within unchecked context.</target>
<source>Some built in operators added in .NET 7 behave differently when overflowing than did the user defined operators in .NET 6 and below. Some operators that used to throw in an unchecked context now no longer throw unless wrapped within a checked context, and some operators that did not previously throw in a checked context now throw unless wrapped in an unchecked context.</source>
buyaa-n marked this conversation as resolved.
Show resolved Hide resolved
<target state="new">Some built in operators added in .NET 7 behave differently when overflowing than did the user defined operators in .NET 6 and below. Some operators that used to throw in an unchecked context now no longer throw unless wrapped within a checked context, and some operators that did not previously throw in a checked context now throw unless wrapped in an unchecked context.</target>
<note />
</trans-unit>
<trans-unit id="PreventNumericIntPtrUIntPtrBehavioralChangesOperatorThrowsMessage">
Expand All @@ -2128,8 +2128,8 @@
<note />
</trans-unit>
<trans-unit id="PreventNumericIntPtrUIntPtrBehavioralChangesTitle">
<source>Prevent from behavioral change</source>
<target state="new">Prevent from behavioral change</target>
<source>Prevent behavioral change</source>
buyaa-n marked this conversation as resolved.
Show resolved Hide resolved
<target state="new">Prevent behavioral change</target>
<note />
</trans-unit>
<trans-unit id="ProvideCorrectArgumentToEnumHasFlagDescription">
Expand Down
8 changes: 4 additions & 4 deletions ...tAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.de.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2118,8 +2118,8 @@
<note />
</trans-unit>
<trans-unit id="PreventNumericIntPtrUIntPtrBehavioralChangesDescription">
<source>Some built in operators added in .NET 7 behave differently than the user defined operatorsi in .NET 6 and below. Some operators that used to throw in unchecked context while overflowing will not throw anymore unless wrapped within checked context, and some operators that not used to throw in checked context now would throw unless wrapped within unchecked context.</source>
<target state="new">Some built in operators added in .NET 7 behave differently than the user defined operatorsi in .NET 6 and below. Some operators that used to throw in unchecked context while overflowing will not throw anymore unless wrapped within checked context, and some operators that not used to throw in checked context now would throw unless wrapped within unchecked context.</target>
<source>Some built in operators added in .NET 7 behave differently when overflowing than did the user defined operators in .NET 6 and below. Some operators that used to throw in an unchecked context now no longer throw unless wrapped within a checked context, and some operators that did not previously throw in a checked context now throw unless wrapped in an unchecked context.</source>
<target state="new">Some built in operators added in .NET 7 behave differently when overflowing than did the user defined operators in .NET 6 and below. Some operators that used to throw in an unchecked context now no longer throw unless wrapped within a checked context, and some operators that did not previously throw in a checked context now throw unless wrapped in an unchecked context.</target>
<note />
</trans-unit>
<trans-unit id="PreventNumericIntPtrUIntPtrBehavioralChangesOperatorThrowsMessage">
Expand All @@ -2128,8 +2128,8 @@
<note />
</trans-unit>
<trans-unit id="PreventNumericIntPtrUIntPtrBehavioralChangesTitle">
<source>Prevent from behavioral change</source>
<target state="new">Prevent from behavioral change</target>
<source>Prevent behavioral change</source>
<target state="new">Prevent behavioral change</target>
<note />
</trans-unit>
<trans-unit id="ProvideCorrectArgumentToEnumHasFlagDescription">
Expand Down
8 changes: 4 additions & 4 deletions ...tAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.es.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2118,8 +2118,8 @@
<note />
</trans-unit>
<trans-unit id="PreventNumericIntPtrUIntPtrBehavioralChangesDescription">
<source>Some built in operators added in .NET 7 behave differently than the user defined operatorsi in .NET 6 and below. Some operators that used to throw in unchecked context while overflowing will not throw anymore unless wrapped within checked context, and some operators that not used to throw in checked context now would throw unless wrapped within unchecked context.</source>
<target state="new">Some built in operators added in .NET 7 behave differently than the user defined operatorsi in .NET 6 and below. Some operators that used to throw in unchecked context while overflowing will not throw anymore unless wrapped within checked context, and some operators that not used to throw in checked context now would throw unless wrapped within unchecked context.</target>
<source>Some built in operators added in .NET 7 behave differently when overflowing than did the user defined operators in .NET 6 and below. Some operators that used to throw in an unchecked context now no longer throw unless wrapped within a checked context, and some operators that did not previously throw in a checked context now throw unless wrapped in an unchecked context.</source>
<target state="new">Some built in operators added in .NET 7 behave differently when overflowing than did the user defined operators in .NET 6 and below. Some operators that used to throw in an unchecked context now no longer throw unless wrapped within a checked context, and some operators that did not previously throw in a checked context now throw unless wrapped in an unchecked context.</target>
<note />
</trans-unit>
<trans-unit id="PreventNumericIntPtrUIntPtrBehavioralChangesOperatorThrowsMessage">
Expand All @@ -2128,8 +2128,8 @@
<note />
</trans-unit>
<trans-unit id="PreventNumericIntPtrUIntPtrBehavioralChangesTitle">
<source>Prevent from behavioral change</source>
<target state="new">Prevent from behavioral change</target>
<source>Prevent behavioral change</source>
<target state="new">Prevent behavioral change</target>
<note />
</trans-unit>
<trans-unit id="ProvideCorrectArgumentToEnumHasFlagDescription">
Expand Down
8 changes: 4 additions & 4 deletions ...tAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.fr.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2118,8 +2118,8 @@
<note />
</trans-unit>
<trans-unit id="PreventNumericIntPtrUIntPtrBehavioralChangesDescription">
<source>Some built in operators added in .NET 7 behave differently than the user defined operatorsi in .NET 6 and below. Some operators that used to throw in unchecked context while overflowing will not throw anymore unless wrapped within checked context, and some operators that not used to throw in checked context now would throw unless wrapped within unchecked context.</source>
<target state="new">Some built in operators added in .NET 7 behave differently than the user defined operatorsi in .NET 6 and below. Some operators that used to throw in unchecked context while overflowing will not throw anymore unless wrapped within checked context, and some operators that not used to throw in checked context now would throw unless wrapped within unchecked context.</target>
<source>Some built in operators added in .NET 7 behave differently when overflowing than did the user defined operators in .NET 6 and below. Some operators that used to throw in an unchecked context now no longer throw unless wrapped within a checked context, and some operators that did not previously throw in a checked context now throw unless wrapped in an unchecked context.</source>
<target state="new">Some built in operators added in .NET 7 behave differently when overflowing than did the user defined operators in .NET 6 and below. Some operators that used to throw in an unchecked context now no longer throw unless wrapped within a checked context, and some operators that did not previously throw in a checked context now throw unless wrapped in an unchecked context.</target>
<note />
</trans-unit>
<trans-unit id="PreventNumericIntPtrUIntPtrBehavioralChangesOperatorThrowsMessage">
Expand All @@ -2128,8 +2128,8 @@
<note />
</trans-unit>
<trans-unit id="PreventNumericIntPtrUIntPtrBehavioralChangesTitle">
<source>Prevent from behavioral change</source>
<target state="new">Prevent from behavioral change</target>
<source>Prevent behavioral change</source>
<target state="new">Prevent behavioral change</target>
<note />
</trans-unit>
<trans-unit id="ProvideCorrectArgumentToEnumHasFlagDescription">
Expand Down
8 changes: 4 additions & 4 deletions ...tAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.it.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2118,8 +2118,8 @@
<note />
</trans-unit>
<trans-unit id="PreventNumericIntPtrUIntPtrBehavioralChangesDescription">
<source>Some built in operators added in .NET 7 behave differently than the user defined operatorsi in .NET 6 and below. Some operators that used to throw in unchecked context while overflowing will not throw anymore unless wrapped within checked context, and some operators that not used to throw in checked context now would throw unless wrapped within unchecked context.</source>
<target state="new">Some built in operators added in .NET 7 behave differently than the user defined operatorsi in .NET 6 and below. Some operators that used to throw in unchecked context while overflowing will not throw anymore unless wrapped within checked context, and some operators that not used to throw in checked context now would throw unless wrapped within unchecked context.</target>
<source>Some built in operators added in .NET 7 behave differently when overflowing than did the user defined operators in .NET 6 and below. Some operators that used to throw in an unchecked context now no longer throw unless wrapped within a checked context, and some operators that did not previously throw in a checked context now throw unless wrapped in an unchecked context.</source>
<target state="new">Some built in operators added in .NET 7 behave differently when overflowing than did the user defined operators in .NET 6 and below. Some operators that used to throw in an unchecked context now no longer throw unless wrapped within a checked context, and some operators that did not previously throw in a checked context now throw unless wrapped in an unchecked context.</target>
<note />
</trans-unit>
<trans-unit id="PreventNumericIntPtrUIntPtrBehavioralChangesOperatorThrowsMessage">
Expand All @@ -2128,8 +2128,8 @@
<note />
</trans-unit>
<trans-unit id="PreventNumericIntPtrUIntPtrBehavioralChangesTitle">
<source>Prevent from behavioral change</source>
<target state="new">Prevent from behavioral change</target>
<source>Prevent behavioral change</source>
<target state="new">Prevent behavioral change</target>
<note />
</trans-unit>
<trans-unit id="ProvideCorrectArgumentToEnumHasFlagDescription">
Expand Down
8 changes: 4 additions & 4 deletions ...tAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.ja.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2118,8 +2118,8 @@
<note />
</trans-unit>
<trans-unit id="PreventNumericIntPtrUIntPtrBehavioralChangesDescription">
<source>Some built in operators added in .NET 7 behave differently than the user defined operatorsi in .NET 6 and below. Some operators that used to throw in unchecked context while overflowing will not throw anymore unless wrapped within checked context, and some operators that not used to throw in checked context now would throw unless wrapped within unchecked context.</source>
<target state="new">Some built in operators added in .NET 7 behave differently than the user defined operatorsi in .NET 6 and below. Some operators that used to throw in unchecked context while overflowing will not throw anymore unless wrapped within checked context, and some operators that not used to throw in checked context now would throw unless wrapped within unchecked context.</target>
<source>Some built in operators added in .NET 7 behave differently when overflowing than did the user defined operators in .NET 6 and below. Some operators that used to throw in an unchecked context now no longer throw unless wrapped within a checked context, and some operators that did not previously throw in a checked context now throw unless wrapped in an unchecked context.</source>
<target state="new">Some built in operators added in .NET 7 behave differently when overflowing than did the user defined operators in .NET 6 and below. Some operators that used to throw in an unchecked context now no longer throw unless wrapped within a checked context, and some operators that did not previously throw in a checked context now throw unless wrapped in an unchecked context.</target>
<note />
</trans-unit>
<trans-unit id="PreventNumericIntPtrUIntPtrBehavioralChangesOperatorThrowsMessage">
Expand All @@ -2128,8 +2128,8 @@
<note />
</trans-unit>
<trans-unit id="PreventNumericIntPtrUIntPtrBehavioralChangesTitle">
<source>Prevent from behavioral change</source>
<target state="new">Prevent from behavioral change</target>
<source>Prevent behavioral change</source>
<target state="new">Prevent behavioral change</target>
<note />
</trans-unit>
<trans-unit id="ProvideCorrectArgumentToEnumHasFlagDescription">
Expand Down
8 changes: 4 additions & 4 deletions ...tAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.ko.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2118,8 +2118,8 @@
<note />
</trans-unit>
<trans-unit id="PreventNumericIntPtrUIntPtrBehavioralChangesDescription">
<source>Some built in operators added in .NET 7 behave differently than the user defined operatorsi in .NET 6 and below. Some operators that used to throw in unchecked context while overflowing will not throw anymore unless wrapped within checked context, and some operators that not used to throw in checked context now would throw unless wrapped within unchecked context.</source>
<target state="new">Some built in operators added in .NET 7 behave differently than the user defined operatorsi in .NET 6 and below. Some operators that used to throw in unchecked context while overflowing will not throw anymore unless wrapped within checked context, and some operators that not used to throw in checked context now would throw unless wrapped within unchecked context.</target>
<source>Some built in operators added in .NET 7 behave differently when overflowing than did the user defined operators in .NET 6 and below. Some operators that used to throw in an unchecked context now no longer throw unless wrapped within a checked context, and some operators that did not previously throw in a checked context now throw unless wrapped in an unchecked context.</source>
<target state="new">Some built in operators added in .NET 7 behave differently when overflowing than did the user defined operators in .NET 6 and below. Some operators that used to throw in an unchecked context now no longer throw unless wrapped within a checked context, and some operators that did not previously throw in a checked context now throw unless wrapped in an unchecked context.</target>
<note />
</trans-unit>
<trans-unit id="PreventNumericIntPtrUIntPtrBehavioralChangesOperatorThrowsMessage">
Expand All @@ -2128,8 +2128,8 @@
<note />
</trans-unit>
<trans-unit id="PreventNumericIntPtrUIntPtrBehavioralChangesTitle">
<source>Prevent from behavioral change</source>
<target state="new">Prevent from behavioral change</target>
<source>Prevent behavioral change</source>
<target state="new">Prevent behavioral change</target>
<note />
</trans-unit>
<trans-unit id="ProvideCorrectArgumentToEnumHasFlagDescription">
Expand Down
Loading