Update resource analyzers to flag leading and trailing whitespaces #3973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mavasani
reviewed
Aug 7, 2020
| var additionalFileText = @" | ||
| <root> | ||
| <data name=""AnalyzerMessage1"" xml:space=""preserve""> | ||
| <value>Message with trailing whitespace </value> |
There was a problem hiding this comment.
Can you add another scenario where trailing spaces are after a period, similar to the case caught in the original PR, say Message with trailing whitespaces after a period. ? I have a feeling your current logic might be need to be tweaked to move whitespace fixing part above multi-line fixing part.
mavasani
reviewed
Aug 7, 2020
| @@ -605,6 +610,8 @@ private static void AnalyzeMessageCore(string message, IArgumentOperation argume | |||
| fixedMessage = endsWithPeriod ? RemoveTrailingPeriod(fixedMessage) : fixedMessage + "."; | |||
| } | |||
|
|
|||
| fixedMessage = hasLeadingOrTrailingWhitespaces ? RemoveLeadingAndTrailingWhitespaces(fixedMessage) : fixedMessage; | |||
There was a problem hiding this comment.
I think this might have to move ahead to just after we fix line returns but before the above if statement.
mavasani
approved these changes
Aug 7, 2020
mavasani
approved these changes
Aug 9, 2020
Codecov Report
@@ Coverage Diff @@
## master #3973 +/- ##
==========================================
+ Coverage 95.61% 95.63% +0.01%
==========================================
Files 1155 1155
Lines 254900 255462 +562
Branches 15272 15282 +10
==========================================
+ Hits 243724 244299 +575
+ Misses 9215 9214 -1
+ Partials 1961 1949 -12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3958