Fix handling of successor.Destination in UseValueTasksCorrectly #3643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I didn't realize Destination could be null: IntelliSense lied to me again ;-) ("'Destination' is not null here.)
|
@sharwell we really need to fix the IDE wrongly indicating non-nullness for oblivious APIs |
mavasani
approved these changes
May 19, 2020
Codecov Report
@@ Coverage Diff @@
## master #3643 +/- ##
=======================================
Coverage 94.66% 94.66%
=======================================
Files 1071 1071
Lines 244233 244266 +33
Branches 14756 14758 +2
=======================================
+ Hits 231201 231233 +32
Misses 11003 11003
- Partials 2029 2030 +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't realize Destination could be null: IntelliSense lied to me again ;-) ("'Destination' is not null here.)
Fixes #3642