[Static web assets][Fixes #AspNetCore/17079] PublishSingleFile results in 404 errors for Nuget components #1415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s in 404 errors for Nuget components
javiercn
requested review from
ajaybhargavb,
NTaylorMullen,
pranavkm and
rynowak
as code owners
pranavkm
approved these changes
Dec 10, 2019
There was a problem hiding this comment.
This is particularly low risk because we already do this by default for all Content files in the wwwroot directory: https://github.com/aspnet/AspNetCore-Tooling/blob/master/src/Razor/src/Microsoft.NET.Sdk.Razor/Sdk/Sdk.Razor.StaticAssets.ProjectSystem.props#L30. These are effectively the same category of files, we just missed these along with the others.
|
Approved for 3.1.1 |
|
These were approved for 3.1.2, so updating the milestone accordingly /cc @jamshedd |
|
Moved to Mar as per Tactics. Will need to be explicitly approved for Feb, if required. |
|
Moving this back to 3.1.2 (Feb) per later decision from Tactics (@jamshedd , @vivmishra) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Static web assets don't work properly with PublishSingleFile as they aren't excluded (like the rest of the web content is).
This fix simply adds a property and the tests necessary to make sure the assets are excluded when published.
Customer Impact
This blocks customers trying to publish ASP.NET Core apps as single files when the app uses static web assets.
The issue was customer reported dotnet/aspnetcore#17079
Regression?
No, but we broke this really close to 3.0 RTM and used to work before.
Risk
Low. It's a one line change and we've included a test that validates the fix.
Implementation details
Just adds the ExcludeFromSingleFile property to the resolved static web assets to publish.