Fire an ETW event when the background document generator queue is empty #11233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ty, after doing some work
davidwengier
commented
Nov 20, 2024
|
|
||
| namespace Microsoft.AspNetCore.Razor; | ||
|
|
||
| [EventSource(Name = "RazorEventSource")] |
There was a problem hiding this comment.
The alternative to this would just be to steal Roslyn's event source name, or even just use the code markers guid. Not sure what the etiquette there is :)
There was a problem hiding this comment.
Creating a new EventSource makes sense, it makes it easier not to accidently collide with their events.
WardenGnaw
approved these changes
Nov 20, 2024
|
|
||
| namespace Microsoft.AspNetCore.Razor; | ||
|
|
||
| [EventSource(Name = "RazorEventSource")] |
There was a problem hiding this comment.
Creating a new EventSource makes sense, it makes it easier not to accidently collide with their events.
ryzngard
approved these changes
Nov 20, 2024
...Razor/src/Microsoft.AspNetCore.Razor.ProjectEngineHost/Utilities/AsyncBatchingWorkQueue`2.cs
Outdated
Show resolved
Hide resolved
...Razor/src/Microsoft.AspNetCore.Razor.ProjectEngineHost/Utilities/AsyncBatchingWorkQueue`2.cs
Outdated
Show resolved
Hide resolved
...rc/Microsoft.VisualStudio.LanguageServices.Razor/DynamicFiles/BackgroundDocumentGenerator.cs
Outdated
Show resolved
Hide resolved
DustinCampbell
approved these changes
Nov 20, 2024
| delay, | ||
| processBatchAsync: ProcessBatchAsync, | ||
| equalityComparer: null, | ||
| idleAction: () => RazorEventSource.Instance.BackgroundDocumentGeneratorIdle(), |
There was a problem hiding this comment.
nit: I think you can just pass the method group here rather than wrapping it in a lambda.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was musing the other day about ETW events possibly being useful in tracking down the Speedometer regression I was looking in to, and then along comes #11232 which is a great excuse to add some ETW event infrastructure to our lives.
The idea here is that RPS/Speedometer tests can wait for Razor to be "ready" by looking for this event, rather than
Thread.Sleeping. Anecdotally on my machine, when loading OrchardCore, this event fires once a couple of minutes after solution load, so seems like a reasonable candidate.Once this is in @WardenGnaw will try it out and if it's not good, we'll pop some more events somewhere.
Will need to follow up with PR(s?) to add this event source name to the list, but I need to work out where to do that first :)