ProjectHotReloadSession updates #9586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduces duplication, making call sites easier to read.
`CreateManagedDeltaApplier` returns a non-null value, so we don't have to perform a further check here.
LittleLittleCloud
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing #9555 I spent some time to familiarize myself with Hot Reload.
Here are a few clean ups that I found in
ProjectHotReloadSession. The major ones are:@LittleLittleCloud, I'm pretty sure this doesn't conflict with your PR, but I will hold off on merging until after your PR goes in.
Microsoft Reviewers: Open in CodeFlow