Change Trimming to TrimMode. Set PublishTrimmed to true when setting TrimMode to full. #9297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TrimMode to full.
melytc
force-pushed
the
native-aot-fix
branch
from
8774337 to
fe143ab
Compare
drewnoakes
added
the
Feature-Project-Properties-Designer
tmeschter
reviewed
Oct 26, 2023
...System/VS/Properties/InterceptedProjectProperties/BuildPropertyPage/TrimModeValueProvider.cs
Outdated
Show resolved
Hide resolved
tmeschter
approved these changes
Oct 26, 2023
agocke
reviewed
Oct 26, 2023
...System/VS/Properties/InterceptedProjectProperties/BuildPropertyPage/TrimModeValueProvider.cs
Outdated
Show resolved
Hide resolved
melytc
force-pushed
the
native-aot-fix
branch
from
06d8c6d to
529cffb
Compare
…rtyPage (Publish category).
melytc
force-pushed
the
native-aot-fix
branch
from
529cffb to
fb46a96
Compare
eerhardt
reviewed
Oct 27, 2023
....VisualStudio.ProjectSystem.Managed/ProjectSystem/Rules/PropertyPages/BuildPropertyPage.xaml
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Oct 27, 2023
....VisualStudio.ProjectSystem.Managed/ProjectSystem/Rules/PropertyPages/BuildPropertyPage.xaml
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Oct 27, 2023
....VisualStudio.ProjectSystem.Managed/ProjectSystem/Rules/PropertyPages/BuildPropertyPage.xaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Eric Erhardt <[email protected]>
melytc
force-pushed
the
native-aot-fix
branch
from
fd29268 to
f98a5b7
Compare
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@eerhardt noticed these changes were needed.
Context from email thread:
The
Trimmingoption doesn’t work.Setting it, sets
<Trimming>full</Trimming>, but the real property is namedTrimMode.Just setting
TrimModeby itself doesn’t change the publishing at all. We also need to setPublishTrimmedto true.Microsoft Reviewers: Open in CodeFlow