-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign benchmarks for culture-specific string operations #892
Merged
adamsitnik
merged 7 commits into
dotnet:master
from
adamsitnik:stringBenchmarksRedesign
Sep 23, 2019
Merged
Redesign benchmarks for culture-specific string operations #892
adamsitnik
merged 7 commits into
dotnet:master
from
adamsitnik:stringBenchmarksRedesign
Sep 23, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
reviewed
Sep 20, 2019
src/benchmarks/micro/corefx/System.Globalization/Perf.StringCultureSpecific.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Sep 20, 2019
src/benchmarks/micro/corefx/System.Globalization/Perf.StringCultureSpecific.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Sep 20, 2019
src/benchmarks/micro/corefx/System.Globalization/Perf.StringCultureSpecific.cs
Outdated
Show resolved
Hide resolved
tarekgh
reviewed
Sep 20, 2019
src/benchmarks/micro/corefx/System.Globalization/Perf.StringCultureSpecific.cs
Outdated
Show resolved
Hide resolved
tarekgh
reviewed
Sep 20, 2019
src/benchmarks/micro/corefx/System.Globalization/Perf.StringCultureSpecific.cs
Outdated
Show resolved
Hide resolved
tarekgh
approved these changes
Sep 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modulo @jkotas comments, LGTM
gfoidl
reviewed
Sep 21, 2019
src/benchmarks/micro/corefx/System.Globalization/Perf.StringCultureSpecific.cs
Outdated
Show resolved
Hide resolved
…pendent execution paths)
…cution path, not dependent on size or high chars)
jkotas
approved these changes
Sep 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The culture-specific string benchmarks we had so far were using a very small and simple input and were testing very few cultures and
CompareOptions
. This is why we have missed issues like https://github.com/dotnet/corefx/issues/40674This is my proposal for fixing it.
Instead of using some made-up text, we are using part of "Alice's Adventures in Wonderland" book. It contains mostly simply ASCII characters, but also some "high" chars that get special treatment and hit the slow path.
The tested matrix now is:
I've removed the old benchmarks that would now be duplicated.
Moreover I've realized that
Perf_CompareInfo
had a serious bug inside - the strings were always identical becausesource
argument was never used..performance/src/benchmarks/micro/corefx/System.Globalization/Perf.CompareInfo.cs
Lines 14 to 24 in 0c626c0
Fixes #885