[wasm] Explicitly enable JsonSerializerIsReflectionEnabledByDefault #3115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Running a test build of this on dotnet-runtime-perf . |
cincuranet
previously approved these changes
Jul 10, 2023
radical
changed the title
|
It needs to be set for the project generated by BDN, and not the original MicroBenchmarks project. |
This reverts commit 2b7a6c8.
|
Updated the PR description also, but feel free to change anything. |
|
Also, this does not need to wait for the CI run, since that might not even complete at all due to other issues (fewer available machines for PRs at least). I have verified the fix locally. |
lewing
approved these changes
Jul 10, 2023
|
I can't merge on red @dotnet/dotnet-perf-admin |
|
The sdk_scenarios ones will get fixed by #3116 AFAIU. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dotnet/runtime#88480 changed the default for
$(JsonSerializerIsReflectionEnabledByDefault)tofalse, which breaks wasm benchmarks using STJ serializer with reflection.Fixes dotnet/runtime#88610