Avoid sending cluster manifest to client if client already has the latest version

[453873]

Fixes #8722

Microsoft Reviewers: Open in CodeFlow

[453873]

@dotnet-policy-service agree

[HermesNew]

Sorry, we found that there was a code omission when submitting the PR. We will submit another PR later.

private ConcurrentDictionary<SiloAddress, MajorMinorVersion> siloAddressVersionMap = new ConcurrentDictionary<SiloAddress, MajorMinorVersion>();

[453873]

I find bug, every silo address need compare clusterManifest version，new patch is commit.

[HermesNew]

@ReubenBond There are two items that have not passed the test. Could you please check them?

[ReubenBond]

I pushed a change, I think this is the right approach and should achieve the behavior you're looking for.

[HermesNew]

The key point of this issue is comparing versions of the same SiloHost.So it is necessary to update the version according to Silohost.

[ReubenBond]

@HermesNew the current version in this PR should accomplish that - do you see issues with the implementation here?

[ReubenBond]

@HermesNew @453873, please take a look at the current version and let me know if you have any issues with it. I will merge and we can include it in the next set of releases (7.2.5 & 8.0.0)

[HermesNew]

@ReubenBond Sorry, I've been very busy these past few days. Tomorrow we will release a version ourselves to verify whether this issue has been resolved.

[ReubenBond]

No problem at all, thank you @HermesNew!

[HermesNew]

@ReubenBond I don't see any code for this issue in the 7. x branch. We are using. net7.0, so we can only release this version. My fork is the main code, and the. net SDK is already .net8.0.

[ReubenBond]

@HermesNew We can backport this to the 7.x branch - usually, we would do that after merging the PR