Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid hiding the stack of exceptions thrown from user code #8706

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Avoid hiding the stack of exceptions thrown from user code #8706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions src/Orleans.Core.Abstractions/Runtime/GrainReference.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,7 +540,6 @@ public void AddInvokeMethodOptions(InvokeMethodOptions options)
}

/// <inheritdoc/>
[DebuggerHidden]
public abstract ValueTask<Response> Invoke();

/// <inheritdoc/>
Expand Down Expand Up @@ -586,7 +585,6 @@ public void AddInvokeMethodOptions(InvokeMethodOptions options)
[SerializerTransparent]
public abstract class Request : RequestBase
{
[DebuggerHidden]
public sealed override ValueTask<Response> Invoke()
{
try
Expand All @@ -606,7 +604,6 @@ public sealed override ValueTask<Response> Invoke()
}
}

[DebuggerHidden]
private static async ValueTask<Response> CompleteInvokeAsync(ValueTask resultTask)
{
try
Expand All @@ -621,7 +618,6 @@ private static async ValueTask<Response> CompleteInvokeAsync(ValueTask resultTas
}

// Generated
[DebuggerHidden]
protected abstract ValueTask InvokeInner();
}

Expand All @@ -635,7 +631,6 @@ private static async ValueTask<Response> CompleteInvokeAsync(ValueTask resultTas
public abstract class Request<TResult> : RequestBase
{
/// <inheritdoc/>
[DebuggerHidden]
public sealed override ValueTask<Response> Invoke()
{
try
Expand All @@ -654,7 +649,6 @@ public sealed override ValueTask<Response> Invoke()
}
}

[DebuggerHidden]
private static async ValueTask<Response> CompleteInvokeAsync(ValueTask<TResult> resultTask)
{
try
Expand All @@ -672,7 +666,6 @@ private static async ValueTask<Response> CompleteInvokeAsync(ValueTask<TResult>
/// Invokes the request against the target.
/// </summary>
/// <returns>The invocation result.</returns>
[DebuggerHidden]
protected abstract ValueTask<TResult> InvokeInner();
}

Expand All @@ -686,7 +679,6 @@ private static async ValueTask<Response> CompleteInvokeAsync(ValueTask<TResult>
public abstract class TaskRequest<TResult> : RequestBase
{
/// <inheritdoc/>
[DebuggerHidden]
public sealed override ValueTask<Response> Invoke()
{
try
Expand All @@ -706,7 +698,6 @@ public sealed override ValueTask<Response> Invoke()
}
}

[DebuggerHidden]
private static async ValueTask<Response> CompleteInvokeAsync(Task<TResult> resultTask)
{
try
Expand All @@ -724,7 +715,6 @@ private static async ValueTask<Response> CompleteInvokeAsync(Task<TResult> resul
/// Invokes the request against the target.
/// </summary>
/// <returns>The invocation result.</returns>
[DebuggerHidden]
protected abstract Task<TResult> InvokeInner();
}

Expand All @@ -735,7 +725,6 @@ private static async ValueTask<Response> CompleteInvokeAsync(Task<TResult> resul
public abstract class TaskRequest : RequestBase
{
/// <inheritdoc/>
[DebuggerHidden]
public sealed override ValueTask<Response> Invoke()
{
try
Expand All @@ -756,7 +745,6 @@ public sealed override ValueTask<Response> Invoke()
}
}

[DebuggerHidden]
private static async ValueTask<Response> CompleteInvokeAsync(Task resultTask)
{
try
Expand All @@ -774,7 +762,6 @@ private static async ValueTask<Response> CompleteInvokeAsync(Task resultTask)
/// Invokes the request against the target.
/// </summary>
/// <returns>The invocation result.</returns>
[DebuggerHidden]
protected abstract Task InvokeInner();
}

Expand All @@ -791,7 +778,6 @@ protected VoidRequest()
}

/// <inheritdoc/>
[DebuggerHidden]
public sealed override ValueTask<Response> Invoke()
{
try
Expand All @@ -808,7 +794,6 @@ public sealed override ValueTask<Response> Invoke()
/// <summary>
/// Invokes the request against the target.
/// </summary>
[DebuggerHidden]
protected abstract void InvokeInner();
}
}
1 change: 0 additions & 1 deletion src/Orleans.Runtime/Services/GrainService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ protected GrainServiceStatus Status

/// <summary>Only to make Reflection happy. Do not use it in your implementation</summary>
[System.ComponentModel.EditorBrowsable(System.ComponentModel.EditorBrowsableState.Never)]
[System.Diagnostics.DebuggerHidden]
protected GrainService() : base()
{
throw new Exception("This should not be constructed by client code.");
Expand Down
14 changes: 0 additions & 14 deletions test/Orleans.Serialization.UnitTests/Request.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ public abstract class UnitTestRequestBase : IInvokable
[GenerateSerializer]
public abstract class UnitTestRequest : UnitTestRequestBase
{
[DebuggerHidden]
public sealed override ValueTask<Response> Invoke()
{
try
Expand All @@ -48,7 +47,6 @@ public sealed override ValueTask<Response> Invoke()
}
}

[DebuggerHidden]
private static async ValueTask<Response> CompleteInvokeAsync(ValueTask resultTask)
{
try
Expand All @@ -63,14 +61,12 @@ private static async ValueTask<Response> CompleteInvokeAsync(ValueTask resultTas
}

// Generated
[DebuggerHidden]
protected abstract ValueTask InvokeInner();
}

[GenerateSerializer]
public abstract class UnitTestRequest<TResult> : UnitTestRequestBase
{
[DebuggerHidden]
public sealed override ValueTask<Response> Invoke()
{
try
Expand All @@ -89,7 +85,6 @@ public sealed override ValueTask<Response> Invoke()
}
}

[DebuggerHidden]
private static async ValueTask<Response> CompleteInvokeAsync(ValueTask<TResult> resultTask)
{
try
Expand All @@ -104,14 +99,12 @@ private static async ValueTask<Response> CompleteInvokeAsync(ValueTask<TResult>
}

// Generated
[DebuggerHidden]
protected abstract ValueTask<TResult> InvokeInner();
}

[GenerateSerializer]
public abstract class UnitTestTaskRequest<TResult> : UnitTestRequestBase
{
[DebuggerHidden]
public sealed override ValueTask<Response> Invoke()
{
try
Expand All @@ -131,7 +124,6 @@ public sealed override ValueTask<Response> Invoke()
}
}

[DebuggerHidden]
private static async ValueTask<Response> CompleteInvokeAsync(Task<TResult> resultTask)
{
try
Expand All @@ -146,14 +138,12 @@ private static async ValueTask<Response> CompleteInvokeAsync(Task<TResult> resul
}

// Generated
[DebuggerHidden]
protected abstract Task<TResult> InvokeInner();
}

[GenerateSerializer]
public abstract class UnitTestTaskRequest : UnitTestRequestBase
{
[DebuggerHidden]
public sealed override ValueTask<Response> Invoke()
{
try
Expand All @@ -174,7 +164,6 @@ public sealed override ValueTask<Response> Invoke()
}
}

[DebuggerHidden]
private static async ValueTask<Response> CompleteInvokeAsync(Task resultTask)
{
try
Expand All @@ -189,14 +178,12 @@ private static async ValueTask<Response> CompleteInvokeAsync(Task resultTask)
}

// Generated
[DebuggerHidden]
protected abstract Task InvokeInner();
}

[GenerateSerializer]
public abstract class UnitTestVoidRequest : UnitTestRequestBase
{
[DebuggerHidden]
public sealed override ValueTask<Response> Invoke()
{
try
Expand All @@ -211,7 +198,6 @@ public sealed override ValueTask<Response> Invoke()
}

// Generated
[DebuggerHidden]
protected abstract void InvokeInner();
}
}