Close connection when invalid framing is detected #8692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o ensure that corruption triggers connection shutdown.
ReubenBond
force-pushed
the
fix/messaging/stuck-after-bad-framing
branch
2 times, most recently
from
dadbdf5 to
d1fda91
Compare
ReubenBond
force-pushed
the
fix/messaging/stuck-after-bad-framing
branch
from
d1fda91 to
0289290
Compare
IEvangelist
approved these changes
Oct 30, 2023
Co-authored-by: David Pine <[email protected]>
benjaminpetit
pushed a commit
to benjaminpetit/orleans
that referenced
this pull request
Nov 3, 2023
* Ensure message is always set to null before deframing/deserializing to ensure that corruption triggers connection shutdown. * Close connection when invalid framing is detected * Fix tests * Avoid complex exception filters * Update src/Orleans.Core/Messaging/InvalidMessageFrameException.cs Co-authored-by: David Pine <[email protected]> --------- Co-authored-by: David Pine <[email protected]>
benjaminpetit
added a commit
to benjaminpetit/orleans
that referenced
this pull request
Nov 3, 2023
commit 7a4aa39 Author: Benjamin Petit <[email protected]> Date: Thu Nov 2 15:31:44 2023 +0100 Merge and fix build commit 54f8a67 Merge: 8146138 2a0996c Author: Benjamin Petit <[email protected]> Date: Thu Nov 2 15:14:43 2023 +0100 Merge branch 'main' of github.com:dotnet/orleans into upgrade/dotnet8-rc2 commit 8146138 Author: Benjamin Petit <[email protected]> Date: Thu Nov 2 15:05:02 2023 +0100 fake commit commit 2a0996c Author: Reuben Bond <[email protected]> Date: Thu Nov 2 06:04:30 2023 -0700 Improve grain directory cache consistency (dotnet#8696) commit b4ef03e Author: Reuben Bond <[email protected]> Date: Tue Oct 31 08:42:10 2023 -0700 Cosmos DB: support custom partition key value providers (dotnet#8694) commit b5bb0b7 Author: Reuben Bond <[email protected]> Date: Tue Oct 31 08:41:46 2023 -0700 Cosmos DB: allow customization of retry logic and partition key path (dotnet#8693) commit d3e7d94 Author: Reuben Bond <[email protected]> Date: Tue Oct 31 08:40:28 2023 -0700 Close connection when invalid framing is detected (dotnet#8692) * Ensure message is always set to null before deframing/deserializing to ensure that corruption triggers connection shutdown. * Close connection when invalid framing is detected * Fix tests * Avoid complex exception filters * Update src/Orleans.Core/Messaging/InvalidMessageFrameException.cs Co-authored-by: David Pine <[email protected]> --------- Co-authored-by: David Pine <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue which was preventing connections from being closed when invalid framing was encountered.
Microsoft Reviewers: Open in CodeFlow