In GrainDirectoryResolver, replace HasNonDefaultDirectory with IsUsingDhtDirectory #8660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReubenBond
approved these changes
Oct 11, 2023
ReubenBond
reviewed
Oct 11, 2023
| .ConfigureLogging(builder => builder.AddProvider(new XunitLoggerProvider(output))) | ||
| .UseLocalhostClustering(); | ||
| }); | ||
| this.host = hostBuilder.Build(); |
There was a problem hiding this comment.
Even though it's not started, we should dispose of this after the tests complete
There was a problem hiding this comment.
@benjaminpetit we can fix this in a follow-up
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8632
HasNonDefaultDirectorywas used to check if the directory was the default builtin (DHT) directory but was causing some logic issue when the default directory was overridden during config.I renamed the method name and changed the logic, so it returns
trueonly if the DHT directory is used for the target grain type.Microsoft Reviewers: Open in CodeFlow